MailTarget: fix "From" errors (bug introduced in NLog 4.3.2) #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
304NotModified
force-pushed
the
improve-mail-from-property
branch
5 times, most recently
from
be8b3dd
to
59d9952
Compare
- try-catch for reading SmtpSection. - MailSettings should not be public (only in 4.3.2) - Improve checking of "From" and overriding - Improve test cases.
304NotModified
force-pushed
the
improve-mail-from-property
branch
from
59d9952
to
52294ad
Compare
Current coverage is 75.45%@@ master #1411 diff @@
==========================================
Files 267 267
Lines 15977 15990 +13
Methods 0 0
Messages 0 0
Branches 1720 1724 +4
==========================================
- Hits 12072 12065 -7
- Misses 3497 3516 +19
- Partials 408 409 +1
|
|
:( Codecov still buggy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1407