Add failing (skipped) test for removing extra files during archive cleanup. #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create unit for issue #1681. - When clearing out archive files exceeding maxArchiveFiles, NLog should not delete all files in the directory. Only files matching the target's archiveFileName pattern. - Create test for 2 applications sharing the same archive directory. - Create test for 2 applications sharing same archive directory and 1 application containing multiple targets to the same archive directory. ** Expected outcome of this should be verified **
…m/rymk/NLog into rymk-1681-keep-x-archive-files-unit-test
304NotModified
changed the title
304NotModified
force-pushed
the
rymk-1681-keep-x-archive-files-unit-test
branch
from
978ae14
to
2c27d25
Compare
304NotModified
force-pushed
the
rymk-1681-keep-x-archive-files-unit-test
branch
from
2c27d25
to
10f178b
Compare
Current coverage is 81% (diff: 100%)@@ master #1788 diff @@
==========================================
Files 274 274
Lines 18256 18256
Methods 2834 2834
Messages 0 0
Branches 2091 2091
==========================================
- Hits 14876 14866 -10
- Misses 2898 2908 +10
Partials 482 482
|
304NotModified
added
the
file-archiving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #1701
This change is