FileTarget - Skip FileSystemWatcher unless ConcurrentWrites=true #3322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve #3321
When running on a non-Windows platform with ConcurrentWrites=false, then just use simple polling of
File.Exists()
before every file-write (throttled to only be done once every 1 sec).The polling on non-windows-platform can be disabled by
KeepFileOpen=false
orConcurrentWrites=true
orEnableFileDelete=false
.PR #1878 introduced the use of
FileSystemWatcher
to improveKeepFileOpen=true + EnableFileDelete=true
on Windows. But it was a mixed gift for other platforms.