AsyncTargetWrapper - Do not schedule lazy writer timer, when other active writer #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we reproduce it locally? |
Not anywhere near the thread-amount that the issue showed. It is probably similar to #3412 |
snakefoot
force-pushed
the
AsyncTargetWrapperThrottleTimer
branch
from
d9ad202
to
3b39716
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
OK, I think we should merge it as it won't hurt any way? Or do you like to wait for a confirmation? |
|
I think it should just be merged. Since all evidence was lost (would really have liked to see the internal logger output) and apparently not easy to re-produce. |
|
merged 👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve #3789. Hard to write an unit-test as it is hard to reproduce (Not even sure it is the issue).