ExceptionLayoutRenderer - Separator with basic Layout support #4583
+110
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
layout-separator2
branch
from
7a5e32b
to
302e2b8
Compare
snakefoot
changed the title
This was referenced Sep 26, 2021
snakefoot
changed the title
snakefoot
changed the title
snakefoot
added
enhancement
|
Kudos, SonarCloud Quality Gate passed! |
snakefoot
changed the title
|
@304NotModified Unless you are completely against this, then I would like commit and proceed with adding basic layout support for the other seperators. So NLog 5.0-preview2 can get out. |
For the exception layout renderer? That sounds fine to me. |
304NotModified
approved these changes
Oct 2, 2021
Was thinking to also fix:
|
|
Ah OK, good idea :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2249, so it is possible for users to specify
${newline}in the NLog.config for the Separator-property.Also changes property-parsing so it work for LayoutRenderer-string-options, so it is consistent with NLog-Target-options and NLog-Layout-options.
ExceptionLayoutRendereris very special since it allows users to override the rendering-methods for the individual parts. So the backing-field remains a string to ensure predictable behavior for the users, that wants to override rendering-methods.