Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InternalLogger IncludeTimestamp = true by default to restore behavior from startup-settings #4775

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Jan 21, 2022

Fix behavior-change introduced with #4184 (Skips loading settings at startup, so no longer assigning fallback true)

IncludeTimestamp = GetSetting("nlog.internalLogIncludeTimestamp", "NLOG_INTERNAL_INCLUDE_TIMESTAMP", true);

@snakefoot snakefoot added the bug Bug report / Bug fix label Jan 21, 2022
@snakefoot snakefoot added this to the 5.0 (new) milestone Jan 21, 2022
@snakefoot snakefoot changed the title InternalLogger IncludeTimestamp = true by default to restore behavior from default-settings InternalLogger IncludeTimestamp = true by default to restore behavior from startup-settings Jan 21, 2022
@snakefoot snakefoot enabled auto-merge (squash) January 21, 2022 23:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 17d6bec into NLog:dev Jan 21, 2022
@snakefoot snakefoot deleted the internallogger-fix-timestamp branch July 30, 2022 10:38
@snakefoot snakefoot added refactoring and removed bug Bug report / Bug fix labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant