-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nano-gemm
instead of matrixmultiply
#292
Conversation
Using the 22 GB-sized flavour-basis EKO
to evolve the corresponding grid. With
That's a wonderful 25% reduction in runtime! BTW: the old runtime (with OpenBLAS even) was
and the difference comes from the fact that I used an evolution-basis EKO that's much bigger due to the rotation: 45 GB. |
Hi, Edit0: Your benchmark seems to be too long for experiment. I would appreciate, if you provide steps for smaller version of your benchmark test |
Hi @mert-kurttutan, The linear algebra routines are used in an operation that we call 'evolution', and some faster running evolutions are used in our integration tests. See this file: pineappl evolve <INPUT> <EKO> <OUTPUT> <CONV_FUNS> The integration tests simply verify the output. For examples of how the arguments are used have a look at the tests. To run them successfully, you'll need the test data that is passed to the CLI, which you can download here. It's probably easier to copy and run the The installation is probably a bit tricky, please read https://nnpdf.github.io/pineappl/docs/installation.html#cli-pineappl-for-your-shell for instructions (you will need the evolution feature, all other optional features are not needed). However, before compiling the Rust code, you'll need to install LHAPDF 6.5.4; without this C++ library nothing will compile/run unfortunately. The installation instructions for this library are here. If you have suggestion on how to improve these documents we'd be happy to take your comments into account (best in a separate Issue). While I'm writing this, I realized that in our installation documents we never mention LHAPDF, probably because practically everyone in our community has it installed. This has to be improved. |
Starting from commit 9ca3022 the new baseline is now:
Apparently we did a lot of linear algebra with zeros 😞. |
Since commit 9ca3022 the performance is acceptable and I'd like to avoid adding more dependencies, so I'm closing this as WONTFIX. @mert-kurttutan if you're still interested and/or have question please let me know! |
Here are some benchmarks of the existing code: