add flag to track lake freezing for clm lake #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeniseWorthen
requested review from
uturuncoglu,
junwang-noaa and
DeniseWorthen
and removed request for
junwang-noaa
42 tasks
DeniseWorthen
approved these changes
Dec 19, 2023
35 tasks
junwang-noaa
approved these changes
Dec 20, 2023
|
All tests were done at ufs-community/ufs-weather-model#2044. @DeniseWorthen Can you merge this pr? |
zach1221
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Dec 21, 2023
…nodi + #2047, #2053, and #2056 (#2044) FV3 diagnostic fixes, CCPP fixes for model crashes, new PR template - UFS: - commit message in PR template (#2053) - fix hercules crashes (#2015) - CMEPS & FV3: Bad data from in CCPP CLM Lake physics scheme caused model crashes - Communicate changes to lake ice (Closes #2055, NOAA-EMC/CMEPS#105, NOAA-EMC/fv3atm#741) - unit mismatch (NOAA-EMC/fv3atm#736) - FV3: correct errors in diagnostic calculations - snodi had weasdi data in it (NOAA-EMC/fv3atm#736) - revisions to RUC LSM snowfall melting and accumulation (NOAA-EMC/fv3atm#739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
A new flag is created to track new freezing lake ice and let sfc_diff to calculate stability variables over the new icy grids for GFS PBL in the second surface loop, which otherwise will remain as missing values.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
#104
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
No
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
No RT baseline changes