Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated land-sea mask used for CFSR or GEFS data. #35

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

binli2337
Copy link
Collaborator

@binli2337 binli2337 commented Mar 9, 2021

Description of changes

The land-sea masks used in CDEPS for CFSR/GEFS data sources are different from those used in NEMS_datm.

Specific notes

The med_map_mod.F90 file needs to be updated.

CMEPS Issues Fixed: #34

Are changes expected to change answers?
No

@DeniseWorthen
Copy link
Collaborator

Thanks Bin. I tested Ufuk's PIO changes when he had the PR to ESCOMP and I know they're fine for us. Do you need those changes brought in right away?

@binli2337
Copy link
Collaborator Author

@DeniseWorthen Yes, please bring those changes to NOAA-EMC/CMEPS. Thanks!

@DeniseWorthen
Copy link
Collaborator

I'm confused about the process here. Are we merging this to develop independent of a ufs-weather pr?

I see this is a minor change; are we planning on merging it to emc/develop and then after that bring in the latest CMEPS master?

@binli2337
Copy link
Collaborator Author

@DeniseWorthen Please submit a new CMEPS PR that will include changes from ESCOMP/CMEPS and my PR. My ufs-weather-model PR will be submitted by this Friday. The CMEPS PR will be merged to the develop branch after all ufs-weather-model regression tests are successful.

@DeniseWorthen
Copy link
Collaborator

@binli2337 Great, thanks. I understand. I'll create a PR soon for updating to the latest ESCOMP/master.

@junwang-noaa I did want to you about pnetcdf. Ufuk did some basic testing when he was merging the PIO changes to ESCOMP. He tested pio using netcdf vs pio using pnetcdf in the coupled model (c96) and he found dramatically different run times---126s w/ pnetcdf vs 700s for netcdf. We should of course verify this in our own testing, but what is preventing us from utilizing pnetcdf ?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 9, 2021 via email

@DeniseWorthen
Copy link
Collaborator

@junwang-noaa I don't understand all the flavors of netcdf. Isn't pnetcdf another name for parallel-netcdf?

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented Mar 10, 2021 via email

@DeniseWorthen DeniseWorthen merged commit 0501d0b into NOAA-EMC:emc/develop Apr 9, 2021
@binli2337 binli2337 deleted the feature/new_mask branch February 5, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update land-sea masks used by CDEPS for cfsr and gefs data sources
3 participants