Add field exchanges required by wave-ice coupling #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add local flag to control whether to write the dststatus file for a particular RH. This prevents writing a dststatus file for consf_aofrac which contains garbage (since the RH is a copy, and dststatus field is not set) or a dststatus file for mapcopy
…SCOMP#268) New field exchanges needed for CESM/CAM CARMA
fix aoflux calculation on agrid and add missing error checks
Description of changes
initialize drydep_nflds to 0 in seq_drydep_readnl.
Issue found when running CAM test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with the nuopc driver. Got the following error (and preceding log message):
[0] (seq_drydep_init) Number of dry deposition fields transfered is **
================================================================================
= BAD TERMINATION OF ONE OF YOUR APPLICATION PROCESSES
= PID 117892 RUNNING AT i042.cgd.ucar.edu
= EXIT CODE: 9
= CLEANING UP REMAINING PROCESSES
= YOU CAN IGNORE THE BELOW CLEANUP MESSAGES
Specific notes
Contributors other than yourself, if any: N/A
CMEPS Issues Fixed (include github issue #): resolves ESCOMP#272
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) No answer changes.
Any User Interface Changes (namelist or namelist defaults changes)? no user interface changes
Testing performed
Testing performed if application target is CESM:
(recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
machines:
details (e.g. failed tests):
(recommended) CESM testlist_drv.xml
machines and compilers:
details (e.g. failed tests):
(optional) CESM prealpha test
machines and compilers
details (e.g. failed tests):
(other) please described in detail
machines and compilers: izumi CAM aux_cam test ERP_Ln9_Vnuopc.ne5pg3_ne5pg3_mg37.QPC6.izumi_nag.cam-outfrq9s_clubbmf with nuopc_driver
details (e.g. failed tests): No failures.
Testing performed if application target is UFS-coupled:
(recommended) UFS-coupled testing
description:
details (e.g. failed tests):
Testing performed if application target is UFS-HAFS:
(recommended) UFS-HAFS testing
description:
details (e.g. failed tests):
Hashes used for testing:
CESM:
repository to check out: ESCOMP/CESM.git
branch/hash:
UFS-coupled, then umbrella repostiory to check out and associated hash:
repository to check out:
branch/hash:
UFS-HAFS, then umbrella repostiory to check out and associated hash:
repository to check out:
branch/hash:
Add ability to send enthalpy fluxes back to MOM6 and at the same time adding a correction term to the sensible heat flux sent back to CAM.
Description of changes Correct replacement of MODEL with COMP_NAME in buildexe. Specific notes Fixes ESCOMP#281 Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial) Any User Interface Changes (namelist or namelist defaults changes)? Testing performed Testing performed if application target is CESM: (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py machines: cheyenne details (e.g. failed tests): (recommended) CESM testlist_drv.xml machines and compilers: details (e.g. failed tests): (optional) CESM prealpha test machines and compilers details (e.g. failed tests): (other) please described in detail machines and compilers details (e.g. failed tests): Build case SMS_D.f09_t061.B1850MOM.cheyenne_intel Testing performed if application target is UFS-coupled: (recommended) UFS-coupled testing description: details (e.g. failed tests): Testing performed if application target is UFS-HAFS: (recommended) UFS-HAFS testing description: details (e.g. failed tests): Hashes used for testing: CESM: repository to check out: ESCOMP/CESM.git branch/hash: UFS-coupled, then umbrella repostiory to check out and associated hash: repository to check out: branch/hash: UFS-HAFS, then umbrella repostiory to check out and associated hash: repository to check out: branch/hash:
### Description of changes Update shr_pio_mod, removing mct centric initialization. Improve logging and make sure logs go to the correct component. Depends on cime branch async_io_in_esmf ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are changes expected to change answers? bfb Any User Interface Changes (namelist or namelist defaults changes)? The modelio namelist has been eliminated and the parameters from that file were moved to nuopc.runconfig, The xml variable PIO_ASYNC_INTERFACE was changed from a global variable to one that could be set individually for each component. ### Testing performed Testing performed if application target is CESM: - [X] (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py - machines: cheyenne intel - details (e.g. failed tests): IRT_N2_Vmct_Ln9.f19_g16_rx1.A.cheyenne_intel fails, apparently expected. - [ ] (recommended) CESM testlist_drv.xml - machines and compilers: - details (e.g. failed tests): - [x] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): - [ ] (other) please described in detail - machines and compilers - details (e.g. failed tests): Testing performed if application target is UFS-coupled: - [ ] (recommended) UFS-coupled testing - description: - details (e.g. failed tests): Testing performed if application target is UFS-HAFS: - [ ] (recommended) UFS-HAFS testing - description: - details (e.g. failed tests): ### Hashes used for testing: - [ ] CESM: - repository to check out: https://github.com/ESCOMP/CESM.git - branch/hash: - [ ] UFS-coupled, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash: - [ ] UFS-HAFS, then umbrella repostiory to check out and associated hash: - repository to check out: - branch/hash:
…ternalstate (ESCOMP#279) Refactors esmFldsExchange_nems.F90 to use separate advertise and initialize phases and to check that a component is present before advertising a field to or from that component. Implements default src and dst mask values in place of the code currently in med_map_mod.F90. Fixes NOAA-EMC#63 and NOAA-EMC#64.
DeniseWorthen
changed the title
15 tasks
BrianCurtis-NOAA
approved these changes
Jul 26, 2022
binli2337
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds fields needed for wave-ice coupling to
esmFieldsExchange_nems. Fixes issue #70Specific notes
For UFS, corresponding fields will need to be added to
fd_nems.yaml.