Fix public dependencies

[DusanJovic-NOAA]

1. Remove finding ZLIB (g2 does not depend on ZLIB, PNG does)
2. Add find_package(bacio)
3. Add find_dependency in package file.
4. Link bacio, png and japser as public dependencies.

[aerorahul]

looks good.

[kgerheiser]

I approve

[BoiVuong-NOAA]

1. Remove finding ZLIB (g2 does not depend on ZLIB, PNG does)

2. Add find_package(bacio)

3. Add find_dependency in package file.

4. Link bacio, png and japser as public dependencies.

[BoiVuong-NOAA]

Kyle,
The G2 requires PNG library.

[kgerheiser]

It finds PNG

NCEPLIBS-g2/CMakeLists.txt

Line 26 in ff8270c

find_package(PNG REQUIRED)

[BoiVuong-NOAA]

But, The build does not build PNG correctly. /gpfs/dell2/emc/modeling/noscrub/Boi.Vuong/ng22/*NCEPLIBS-g2/src/dec_png.c:91: undefined reference to `png_set_longjmp_fn'*

…

On 6/17/2020 4:58 PM, Kyle Gerheiser wrote: It finds PNG https://github.com/NOAA-EMC/NCEPLIBS-g2/blob/ff8270c80b24c2a2864127ffe8dac304bff358d6/CMakeLists.txt#L26 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQMPTTUSLVYZV6PZ5JJLBTRXEU7HANCNFSM4N4QFEUA>.