release/public-v1: issue with find_package(sigio REQUIRED)

[DusanJovic-NOAA]

I am getting this error when I run cmake:

CMake Error at CMakeLists.txt:46 (find_package):                                 
  By not providing "Findsigio.cmake" in CMAKE_MODULE_PATH this project has       
  asked CMake to find a package configuration file provided by "sigio", but      
  CMake did not find one.                                                        
                                                                                 
  Could not find a package configuration file provided by "sigio" with any of    
  the following names:                                                           
                                                                                 
    sigioConfig.cmake                                                            
    sigio-config.cmake                                                           
                                                                                 
  Add the installation prefix of "sigio" to CMAKE_PREFIX_PATH or set             
  "sigio_DIR" to a directory containing one of the above files.  If "sigio"      
  provides a separate development package or SDK, be sure it has been            
  installed.                                                                     
                                                                                 
                                                                                 
-- Configuring incomplete, errors occurred!

There is a file named cmake/Modules/FindSIGIO.cmake. Looks like cmake find_package must use correct (upper case) name of the module, here:

https://github.com/NOAA-EMC/EMC_post/blob/4511de5a221e1b9ba36f336ea60604cda4189c92/CMakeLists.txt#L46

Has this been tested on case-sensitive filesystem?

[climbfuji]

I have not tested the standalone version, the NCEPLIBS umbrella build does this differently by including the libraries with add_subdirectory. The umbrella build itself has of course been tested on case-sensitive file systems. I can try to change the find_package statement and see if it breaks the umbrella build or not.

[kgerheiser]

We output the sigio-config.cmake as lowercase, and FindSIGIO.cmake is capital. So, either we change FindSIGIO.cmake or output the config files as SIGIO-config.cmake.

[climbfuji]

Ok, so how do you want to fix this? I think it doesn't affect the umbrella build at all, because the targets are already defined. I am makingsome changes right now for getting this to work on gaea (got to do with a mixture of OpenMP and non-OpenMP). But if you want to make the changes in the various submodules, then please do so and I will pull them in. I would say we need to be consistent, hence if we decide to lowercase the findXYZ.cmake files, we should do this for all the nceplibs (e.g. also crtm) - or do all uppercase.

[climbfuji]

If this involves a lot of changes, then I'd say do EMC_post and UFS_UTILS only for today (because these are the two libraries than Dusan wants to handle separately as far as I know) and leave the rest for next week after the gaea bugfixes have been committed and tested.

[kgerheiser]

The quickest and most painless solution for now is to just change FindSIGIO.cmake to Findsigio.cmake. Only 1 repo change. Otherwise, there's a lot of changes across many repos.