Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DTC_post into develop branch #131

Merged
merged 611 commits into from
Jun 9, 2020
Merged

Conversation

fossell
Copy link
Contributor

@fossell fossell commented May 29, 2020

This a large merge that incorporates DTC_post contents into develop branch. This includes:

  • Community build mechanisms: configure and compile scripts for non-NOAA platforms, sorc/arch/ directory, changes to build script to add functionality for other non-NOAA platforms (note: retains current EMC procedures for auto-detecting machine)
  • Addition of a few small libraries needed by community (sorc/comlibs) - Note: these already exist in repository history, it does not add to size, just reorganizes
  • Merge with HWRF branch
  • Source code changes are minimal and include bug fixes, new fields, etc.

This branch has been merged with develop and is up-to-date. EMC reg tests were run on Hera successfully with bit-wise results for all tests. Community platform testing was also successful.

One important note: This merge includes new code for outputting Himawari satellite fields (from HWRF group). This requires adding the Himawari coefficient files to (ahi_himawari8.SpcCoeff.bin & ahi_himawari8.TauCoeff.bin) to the fix directory in the EMC regression testing framework on the system (Hera for tests to be successful for rap/hrrr. We have already added "ahi_himawari" to the link_crtm_fix.sh script for GFS special file.

Kate.Fossell and others added 30 commits November 12, 2018 13:59
… These have not been used operationally for a while. This commit is merely to sync the community and emc code bases
…in/, and external/ directories from a successful WRF build, this version compiles and runs successfully
Now contains a new directory "wrf_io/" with its own makefile for building the
relevant WRF code. Now you no longer have to pre-build WRF, only run the
configure script to create a configure.wrf file.

To build this version:

 - Copy in the external/, frame/, inc/, main/, Registry/, and tools/ directories from the RAW UNBUILT WRF source code into the new wrf_io/ directory
 - Copy in a configure.wrf file created with that same WRF source code

Should be able to pare down the above list soon, many of them are only
needed for one or two files (or perhaps ultimately none)

This version was tested with the WRF V4.0 Friendly Release #3 (git hash e96ef955), but it should work for a wide range of WRF code
…ired!

 - Added "wrf_makerules" file to be included in a couple makefiles
   - Contains configure.wrf preamble and postamble, but no
     platform-specific stuff!
 - Still need to copy over WRF directories, *and* properly check out the
   versioned files
 - Modified frame Makefile to remove an unnecessary compilation
   - Hopefully a lot more of this in the future!
to be copied in to wrf_io/ directory

 - Versioned the necessary files in frame/ from the WRF build.
 - Moved depend.common from main/ to frame/, and versioned it
 - Build libwrflib.a in the wrf_io/ directory instead of wrf_io/main/
…rial compile. Tests now work for options 7 and 8 (gfortran serial and parallel)

 - Link in already existing UPP stub mpi library files for WRF serial build
 - Use already existing "sw_dmparallelflag" switch from configure to
   pass -DSTUBMPI flag for serial builds
 - Remove clog.o file which is only needed for log file buffering, which
   is rarely used in WRF and certainly not supported for UPP.
 - While removing log file buffering, also remove a lot of other
   unsupported CPP ifdefs
parm/post_avblflds.xml Outdated Show resolved Hide resolved
@WenMeng-NOAA
Copy link
Collaborator

The regression tests are conducted on Dell, Cray and Hera. No changed results are found. The PR is ready to be merged into develop.

@fossell Will you open an issue on github for the PR so we can track the changes. Thanks!

@fossell
Copy link
Contributor Author

fossell commented Jun 9, 2020

@WenMeng-NOAA Issue #133 has been created.

@WenMeng-NOAA WenMeng-NOAA merged commit 34c7a61 into NOAA-EMC:develop Jun 9, 2020
guoqing-noaa added a commit to guoqing-noaa/UPP that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants