Make UPP for GEFSv12 can be built on both wcoss2 and other machines #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch hotfix/gefs_v12 Changes to be committed: modified: sorc/build_ncep_post.sh Refs: NOAA-EMC#345
|
This is a minor changes, could you please review my changes and create a new tag "gefs_v12.2.0" after the merging? Thanks. @WenMeng-NOAA |
WenMeng-NOAA
approved these changes
Nov 12, 2021
WenMeng-NOAA
added
the
NCEP implementation
|
@XianwuXue-NOAA Could you open an UPP issue for this PR? |
|
I wrote wrong issue number, it should be #342. Should I create a new issue for this? |
|
@XianwuXue-NOAA I modified the link of PR in your issue #342. Now it looks good. |
|
@XianwuXue-NOAA The previous GEFS tag is gefs_v12.0.2. Would you like the new tag as gefs_v12.1.0 or other preferences? |
|
@WenMeng-NOAA since the current GEFS is v12.2.0, so could you please create a tag as "gefs_v12.2.0". Thanks |
|
@XianwuXue-NOAA The tag gefs_v12.2.0 was created. |
|
Thanks @WenMeng-NOAA |
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…-EMC#414) The main modification that this PR makes is that the `exregional_make_ics.sh` and `exregional_make_lbcs.sh` scripts no longer use long (and error-prone) if-statements over physics suites to set the `chgres_cube` namelist variable `thomp_mp_climo_file`; instead, the function `set_thompson_mp_fix_files.sh` that already checks whether Thompson MP is included in the SDF now also returns the new workflow variable `THOMPSON_MP_USED` that indicates whether or not Thompson MP is called by the physics suite, and the `exregional_make_ics.sh` and `exregional_make_lbcs.sh` scripts then use this flag to set the `chgres_cube` namelist variable `thomp_mp_climo_file` appropriately. The improvement being made here is that the developer no longer needs to remember which suites use Thompson MP and which don't, which must be known in order to maintain the long and repeated if-statements over physics suites currently in `exregional_make_ics.sh` and `exregional_make_lbcs.sh`. ## DESCRIPTION OF CHANGES: * In set_thompson_mp_fix_files.sh, set and output via a new function argument the variable thompson_mp_used. If the Thompson microphysics parameterization is being used by the physics suite, this will be set to "TRUE", otherwise it will be set to "FALSE". * In setup.sh: * Set the new workflow variables THOMPSON_MP_CLIMO_FN and THOMPSON_MP_CLIMO_FP. The first contains the name (but not full path) of the aerosol climatology file that may be needed by Thompson MP, and the second contains the full path of this aerosol climatology file (regardless of whether or not Thompson MP is used in the physics suite and regardless of whether or not the external model files contain aerosol data). * Set the new workflow variable THOMPSON_MP_USED (via the call to the set_thompson_mp_fix_files.sh function) that indicates whether or not Thompson MP is called by the physics suite. * Write all three new workflow variables to the experiment variable defintions file (var_defns.sh). * In exregional_make_ics.sh and exregional_make_lbcs.sh, remove suite-dependent if-statements for setting thomp_mp_climo_file. Instead, use a much simpler if-statement that sets this variable to THOMPSON_MP_CLIMO_FP only if Thompson MP is being used AND the external model does not already provide the aerosol fields needed by Thompson MP (which is all external models except the HRRR and the RAP) and otherwise leaves it set to a null string. Note that thomp_mp_climo_file is passed to the namelist file for chgres_cube. * Add a WE2E test (grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GSD_SAR) that uses the FV3GFS (which does not provide aerosol fields) as the external model for ICs and LBCs and uses the GSD_SAR physics suite (which includes Thompson MP). Thus, the aerosol climatology file Thompson_MP_MONTHLY_CLIMO.nc must be used to provide aerosol data to Thompson MP. This test exercises use of this aerosol climatology file in the workflow. ### Improvements: * Add a script (tests/get_expts_status.sh) that obtains the workflow status of all experiments in a specified experiments base directory. * Takes one argument -- the experiments base directory. This is the directory under which all the experiment subdirectories are located. * Assumes that all subdirectories under the base directory are experiment directories. * For each subdirectory/experiment, calls the workflow launch script to update the status of the workflow for that experiment. It then places the result from the launch script in a summary file named expts_status_${YYYYMMDDHHMN}.txt, where ${YYYYMMDDHHMN} is the 4-digit year, 2-digit month, 2-digit day-of-month, 2-digit hour-of-day, and 2-digit minute of the time at which the script was called. The summary file is placed in the experiments base directory. * For each experiment, it prints to screen the name of the experiment and the status of the corresponding workflow ("IN PROGRESS", "SUCCESS", or "FAILURE"). * Edit error messages for clarity. * Clean up comments. ## TESTS CONDUCTED: The following WE2E tests were run successfully on Hera: * grid_RRFS_CONUS_13km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 * grid_RRFS_CONUS_13km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta * grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 * **grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GSD_SAR** * grid_RRFS_CONUS_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta * grid_RRFS_CONUS_25km_modify_DT_ATMOS_LAYOUT_XY_BLOCKSIZE * grid_RRFS_CONUS_3km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta * nco_CONUS_25km_GFDLgrid * nco_RRFS_CONUS_25km_HRRR_RAP The one that directly tests the change in the way the Thompson climatology file is handled is grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GSD_SAR (in bold in the list above). The remaining tests ensure pre-existing functionality is not broken.
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
* Minor bug fix in JREGIONAL_RUN_PYTHON_GRAPHICS * limit the bug fix to RTMA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch hotfix/gefs_v12
Changes to be committed:
modified: sorc/build_ncep_post.sh
Refs: #342