upgrade OPAC aerosol with more advanced MERRA2 aerosol #254

AnningCheng-NOAA · 2021-03-05T21:24:12Z

Description

(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Replace the 5 degree by 5 degree OPAC aerosol with 0.5 degree and 0.625 degree MERRA2 climatological aerosol. The data has been changed and the memory usage by the interpolation code has been decreased.

Is a change of answers expected from this PR?
yes. Expecting improvements on aerosol interactions with radiation and microphysics

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

fixes upgrade OPAC aerosol with more advanced MERRA2 aerosol #257

Testing

How were these changes tested? regression tests
What compilers / HPCs was it tested with? default used by UFS
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) yes. no new tests needed
Have the ufs-weather-model regression test been run? On what platform? has been tested in orion, DELL, and Hera

Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below. yes. Because New forcing from aerosol is used.
Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first? yes
If so add the "waiting for other repos" label and list the upstream PRs

climbfuji · 2021-03-15T21:43:56Z

gfsphysics/physics/aerclm_def.f

@@ -0,0 +1,23 @@
+      module aerclm_def


Please remove this file, IPD is gone.

climbfuji

This PR is behind the authoritative repositories and needs to be updated. I see submodule pointer updates that shouldn't be there (GFDL_atmos_cubed_sphere and ccpp-framework).

* upstream/develop: Add missing OpenMP dependency to ccpp/data/CMakeLists.txt and ccpp/driver/CMakeLists.txt (NOAA-EMC#258) Regional inlinepost (NOAA-EMC#229)

AnningCheng-NOAA · 2021-03-16T14:18:14Z

HI, Dom: I have just brought my branch up to the latest trunk, but I get a message as "No submodule mapping found in .gitmodules for path 'atmos_cubed_sphere' ", when run "git clone --recursive --branch merra2 https://github.com/AnningCheng-NOAA/fv3atm". Do I need to run "git rm atmos_cubed_sphere"? Anning

…

On Mon, Mar 15, 2021 at 5:45 PM Dom Heinzeller ***@***.***> wrote: ***@***.**** requested changes on this pull request. This PR is behind the authoritative repositories and needs to be updated. I see submodule pointer updates that shouldn't be there (GFDL_atmos_cubed_sphere and ccpp-framework). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#254 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQPMIOP6WFTAMBO7LQT6FTTDZ5V5ANCNFSM4YV5GSRQ> .

climbfuji · 2021-03-16T14:21:14Z

HI, Dom: I have just brought my branch up to the latest trunk, but I get a message as "No submodule mapping found in .gitmodules for path 'atmos_cubed_sphere' ", when run "git clone --recursive --branch merra2 https://github.com/AnningCheng-NOAA/fv3atm". Do I need to run "git rm atmos_cubed_sphere"? Anning
…

No, all you need to do is make sure that after pulling in the updates for fv3atm develop, you update the submodule pointer (check out the correct/updated hash) for GFDL_atmos_cubed_sphere:

cd FV3
git remote update
git pull noaa-emc develop # or origin, depending on how you call the remote with url noaa-emc
git status
# if you see sth like "atmos_cubed_sphere (new commits)" then
git submodule update atmos_cubed_sphere

climbfuji

Looks good except for the whitespace/tab changes in .gitmodules, but that can be fixed after ccpp-physics is merged. No need to do now.

climbfuji · 2021-03-16T20:22:47Z

.gitmodules

-	path = atmos_cubed_sphere
-	url = https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere
-	branch = dev/emc
+   path = atmos_cubed_sphere


Please revert all whitespace/tab changes in .gitmodules

done. Extra space and comment lines are removed.

…nto merra2 * 'merra2' of https://github.com/AnningCheng-NOAA/fv3atm: fix the ccpp/framework version and remove space in .gitmodules

climbfuji

Approved pending correct update of the submodule pointer and reversal of .gitmodules change.

yangfanglin · 2021-03-26T21:13:22Z

Thank you Anning and all the code managers involved in making this happen. MERRA2 aerosol is ready for P7 ! One more physics development goal for the UFS prototypes has been reached.

…

---Fanglin

On Fri, Mar 26, 2021 at 3:51 PM Jun Wang ***@***.***> wrote: Merged #254 <#254> into develop. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#254 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKY5N2JJH5BNBYLAVZ3F6Z3TFTQT5ANCNFSM4YV5GSRQ> .

-- *Fanglin Yang, Ph.D.* *Chief, Model Physics Group* *Modeling and Data Assimilation Branch* *NOAA/NWS/NCEP Environmental Modeling Center* *https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ <https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*

* Add NSSL 2-Moment Microphysics * Update data structures to handle the additional tracer species in NSSL microphysics * Add the code files for NSSL microphysics to the CCPP prebuild config * Add suite for NSSL microphysics * Add a CCPP suite to test NSSL microphysics * Initialize ice fluxes and add "tiice" array (#119) (1) Introducing a separate array "tiice" to store internal ice temperature. "tiice" will be added to phyf*nc output only when frac_grid=T. (2) When cplflx=T, initializing ice fluxes by PBL calculated values when fluxes from CICE are unavailable. (3) Adding frac_grid to namelist and no longer modifying it inside FV3GFS_io.F90. frac_grid=F by default. * Remove cheyenne.pgi from CCPP config (#117) remove cheyenne.pgi from CCPP config (ccpp/set_compilers.sh, ccpp/build_ccpp.sh) * develop: merge HWRF version of saSAS with GFS version (#93) * Merge branch 'man_hafs_sas_without_updates_of_dtc_develop_49b73a8f4149ca88f071dbaae81f1769b120f1e0' into HEAD * gfsphysics/physics/GFS_debug.F90: add capability to debug 1-d logical arrays * Clean up error messages in gfsphysics/GFS_layer/GFS_typedefs.F90 Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> * Merge GFDL FV3 dynamic core new (201912) version (#65) * Change 'mytile' to 'mygrid' corresponding to the change in atmos_cubed_sphere * GFS.v16.0.4 physics update (#128) * physics update from GFS.v16.0.4 * GFS.v16.0.4 physics udpate * remove whitespaces in sfc_diff.f * keep z0 unchanged in coupled mode in sfc_diff.f * fix IPD run * point to NCAR ccpp-physics branch Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> * Update for GFDL_atmos_cubed_sphere (dycore GNU bugfix) (#131) * Bugfix for regional runs when dycore is compiled in double precision (#133) * Update .gitmodules and submodule pointer for fv3atm for code review and testing * Revert change to .gitmodules and update submodule pointer for GFDL_atmos_cubed_sphere * Update develop from gsd/develop 2020/06/30 (#134) - output of auxiliary arrays (2d, 3d) from CCPP to assist developers debugging their physics - correctly output 3-dim tendencies for t, u, v, qv, ozone from CCPP physics - mandatory changes for the CCPP framework updates to handle blocked data structures correctly: fix inconsistent use of `horizontal_dimension` (ix) versus `horizontal_loop_extent` (im) and other metadata corrections - remove old pset logic from `ccpp_prebuild_config.py` (was required for CCPP dynamic build) - updates to all suite definition files: change the order of interstitial schemes get_phi_fv3+GFS_suite_interstitial_3 and GFS_DCNV_generic_pre to match the logical flow (does not change the answer) - move CCPP physics initialization calls in `atmos_model.F90` so that the physics can see the data from the restart files at initialization time - add capability to read large-scale and small-scale orographic data when using GSL drag suite - add additional fields to restart files as required for GSL physics updates - new suite definition files for RAP and HRRR configurations - capability to call radiation for the first `nhfrad` physics time steps for cold starts, afterwards on the cycle defined by the radiation time step * Add regression tests with MULTI_GASES (#108) * Update suite_FV3_GFS_2017_fv3wam.xml * Remove unnecessary file from the CCPP prebuild configuration * Add TACC frontera configuration * Update to RAS in CCPP, update submodule pointer for ccpp-framework (CI tests) (NOAA-EMC#252) * Reactivate mass flux arrays * fix the argument list in inline_post_getattr and remove prints and post_gfs_stub.F90 * ccpp/data/GFS_typedefs.F90: correct initialization of Model%fscav * Add FV3_GFS_v16_ras * Cld perts (NOAA-EMC#233) Addition of stochastic physics restarts in netCDF format that will be written at the restart interval, and at end of run. Also, addition of stochastic cloud perturbation and microphyiscs perturbations for SPPT. * upgrade OPAC aerosol with more advanced MERRA2 aerosol (NOAA-EMC#254) * changed .gitmodules to point to merra2 ccpp/physics * revert .gitmodule * update to Larissa version * add atmos_cube_sphere and ccpp/physics as submodules * add submodules of emc-2021-cloud * update ccpp/physics: remove CAPS version mp_nssl_2mom * ccpp/physics update: fix nssl mp reproducibility issue * Updating pointer to ccpp/physics. * Pointing to Christin's branch * Adding new suite for NSSL physics. * Updating suites to match HWT. * Updating gitmodules * Updating pointer to atmos_cubed_sphere. Co-authored-by: Tim Supinie <tsupinie@ou.edu> Co-authored-by: shansun6 <48043606+shansun6@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov> Co-authored-by: XiaqiongZhou-NOAA <48254930+XiaqiongZhou-NOAA@users.noreply.github.com> Co-authored-by: Jun Wang <37633869+junwang-noaa@users.noreply.github.com> Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Phil Pegion <38869668+pjpegion@users.noreply.github.com> Co-authored-by: AnningCheng-NOAA <48297505+AnningCheng-NOAA@users.noreply.github.com> Co-authored-by: Jili Dong <jili.dong@noaa.gov>

…led model (NOAA-EMC#254) * Implements a bugfix for the mapping of ifrac for both nems_orig and nems_frac in CMEPS: issue (NCAR#17)[NOAA-EMC/CMEPS#17] * Adds field-packing for performance improvements in CMEPS: issue (NCAR#23)[NOAA-EMC/CMEPS#23] * Uses module file fv3_debug when DEBUG=Y is specified and fv3_debug is available * Shortens the nems.configure file name used with the coupled model

AnningCheng-NOAA added 2 commits March 5, 2021 15:19

changed .gitmodules to point to merra2 ccpp/physics

69d0772

resloved conflict by adding ccpp-physics

90b66b5

AnningCheng-NOAA mentioned this pull request Mar 12, 2021

upgrade OPAC aerosol with more advanced MERRA2 aerosol ufs-community/ufs-weather-model#472

Closed

AnningCheng-NOAA changed the title ~~changed .gitmodules to point to merra2 ccpp/physics~~ upgrade OPAC aerosol with more advanced MERRA2 aerosol Mar 12, 2021

climbfuji reviewed Mar 15, 2021

View reviewed changes

gfsphysics/physics/aerclm_def.f Outdated

@@ -0,0 +1,23 @@

module aerclm_def

Copy link

Collaborator

climbfuji Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file, IPD is gone.

climbfuji requested changes Mar 15, 2021

View reviewed changes

AnningCheng-NOAA mentioned this pull request Mar 15, 2021

upgraded OPAC aerosol with more advanced MERRA2 aerosol NCAR/ccpp-physics#594

Merged

AnningCheng-NOAA added 3 commits March 16, 2021 08:39

remove GFDL_atmos_cubed_sphere and ccpp-framework from .git module

30051d5

Merge remote-tracking branch 'upstream/develop' into merra2

fab43ee

* upstream/develop: Add missing OpenMP dependency to ccpp/data/CMakeLists.txt and ccpp/driver/CMakeLists.txt (NOAA-EMC#258) Regional inlinepost (NOAA-EMC#229)

remove IPD gfsphysics

dbc9d70

.gitmodules update

1b633bf

climbfuji reviewed Mar 16, 2021

View reviewed changes

AnningCheng-NOAA added 2 commits March 22, 2021 08:59

resolve conflict when update

c5d83d4

remeve spaces and comment line in .gitmodules

a1b1b4b

junwang-noaa mentioned this pull request Mar 23, 2021

upgrade coarse resolution OPAC aerosol with more advanced high resolution MERRA2 aerosol data ufs-community/ufs-weather-model#451

Merged

9 tasks

AnningCheng-NOAA added 4 commits March 23, 2021 11:58

fix the ccpp/framework version and remove space in .gitmodules

5185e2c

fix the ccpp/framework version and remove space in .gitmodules

20064e3

Merge branch 'merra2' of https://github.com/AnningCheng-NOAA/fv3atm i…

41e6ac6

…nto merra2 * 'merra2' of https://github.com/AnningCheng-NOAA/fv3atm: fix the ccpp/framework version and remove space in .gitmodules

fix space in .gitmodules

355133e

DeniseWorthen requested review from climbfuji, junwang-noaa and DusanJovic-NOAA March 25, 2021 14:53

junwang-noaa approved these changes Mar 25, 2021

View reviewed changes

climbfuji approved these changes Mar 25, 2021

View reviewed changes

revert .gitmodule

0e05075

junwang-noaa approved these changes Mar 26, 2021

View reviewed changes

junwang-noaa merged commit 597fe91 into NOAA-EMC:develop Mar 26, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade OPAC aerosol with more advanced MERRA2 aerosol #254

upgrade OPAC aerosol with more advanced MERRA2 aerosol #254

AnningCheng-NOAA commented Mar 5, 2021 •

edited by junwang-noaa

Loading

climbfuji Mar 15, 2021

climbfuji left a comment

AnningCheng-NOAA commented Mar 16, 2021 via email

climbfuji commented Mar 16, 2021

climbfuji left a comment

climbfuji Mar 16, 2021

AnningCheng-NOAA Mar 23, 2021

climbfuji left a comment

yangfanglin commented Mar 26, 2021 via email

upgrade OPAC aerosol with more advanced MERRA2 aerosol #254

upgrade OPAC aerosol with more advanced MERRA2 aerosol #254

Conversation

AnningCheng-NOAA commented Mar 5, 2021 • edited by junwang-noaa Loading

Description

Issue(s) addressed

Testing

Dependencies

climbfuji Mar 15, 2021

Choose a reason for hiding this comment

climbfuji left a comment

Choose a reason for hiding this comment

AnningCheng-NOAA commented Mar 16, 2021 via email

climbfuji commented Mar 16, 2021

climbfuji left a comment

Choose a reason for hiding this comment

climbfuji Mar 16, 2021

Choose a reason for hiding this comment

AnningCheng-NOAA Mar 23, 2021

Choose a reason for hiding this comment

climbfuji left a comment

Choose a reason for hiding this comment

yangfanglin commented Mar 26, 2021 via email

AnningCheng-NOAA commented Mar 5, 2021 •

edited by junwang-noaa

Loading