[production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkbk2004 @JiliDong-NOAA This PR can be closed since it was combined into #802. |
MatthewPyle-NOAA
pushed a commit
that referenced
this pull request
Mar 19, 2024
…es RRFS.v1 (#802) * "point to the mynn pbl, HAILCAST diagnostic updates; allocate rho_dry to zero size when not in use" * "point to the smoke updates for RRFS.v1, and update input for smoke" * "merge fv3atm PR #801 from Jili (clouds fix)" * "point to hashes ufs-community/ccpp-physics@85fabc0 and NOAA-EMC/GFDL_atmos_cubed_sphere@fab198c"
|
@JiliDong-NOAA Since this was merged in #802, please close this PR. As the developer, you should have permissions to do that. |
grantfirl
pushed a commit
to grantfirl/fv3atm
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will address zero cloud fraction issue for RRFS ensemble members using GFS PBL and G-F convection by adding SGS cloud to ccpp SDF and changing conv_cf_opt to Xu-Randall for convective cloud fraction computation for those members.
The change to fv3atm is to add conv_cf_opt as an input namelist parameter for runtime switch (conv_cf_opt=1 for GFS PBL members) and add sgs cloud to related ccpp SDFs.
Issue(s) addressed
#800
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Intel on Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
No. No RTs using RRFS ensemble physics suites.
Have the ufs-weather-model regression test been run? On what platform?
Not yet. But no changes expected for RT baseline.
No
Dependencies
ufs-community/ccpp-physics#186