Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stage initial conditions for cycled and forecast-only via stage_ic job. #2475

Open
aerorahul opened this issue Apr 9, 2024 · 2 comments
Open
Assignees
Labels
feature New feature or request

Comments

@aerorahul
Copy link
Contributor

aerorahul commented Apr 9, 2024

What new functionality do you need?

Presently, the cycled initial conditions are staged by setup_expt.py.
The initial conditions for forecast-only are staged by a job stage_ic.

This feature requests development of the stage_ic job to stage cycled initial conditions in addition to the ones for forecast-only.

What are the requirements for the new functionality?

The new stage_ic job should be able to handle both cycled and forecast-only modes as well as for gfs and gefs systems.
Extra points for making the job generic to allow users to provide (files) initial conditions of their choosing from arbitrary locations and structure.

Acceptance Criteria

Add the stage_ic job to the first half-cycle of the cycled mode.

@aerorahul aerorahul added feature New feature or request triage Issues that are triage labels Apr 9, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA removed the triage Issues that are triage label Apr 10, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

@KateFriedman-NOAA See #2559 for changes relevant to this issue

@WalterKolczynski-NOAA
Copy link
Contributor

@KateFriedman-NOAA #2545 is also adding options to stage_ic you'll have to handle

KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 14, 2024
- Change the extension of the exglobal_stage ex-script
from "sh" to "py".

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 14, 2024
- Update script extension for ex-script from "sh" to "py".
- Pull COM* variable declares up from ex-script.

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 14, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 14, 2024
Remove the functions and calls to set up
symlinks to ICs in ROTDIR.

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 14, 2024
- Add initial new yaml files for staging information
- Add new stage.py to python tasks.
- Add first draft pythonization of stage ex-script.

Much more work is still to be done.

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 14, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
Revert changes to workflow/setup_expt.py; will do in later task

Refs NOAA-EMC#2475

* upstream/develop:
  Sea-ice analysis insertion (NOAA-EMC#2584)
  Refactored archiving (NOAA-EMC#2491)
  Add remove RUNDIRS step in CI before creating experements (NOAA-EMC#2607)
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
Also fix to set target and remove source

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
Add target, remove source, and update file info

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
Update to use mkdir and copy instead of target and required

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 22, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 23, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 23, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 23, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 23, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 23, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 23, 2024
If RUN=gefs add keys_gefs to keys.

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 30, 2024
Set to .false. by default; needed for staging job

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 30, 2024
- remove master yaml, no longer using
- update fv3_cold, ice, ocean, and wave yamls

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 30, 2024
- General cleanup
- Rework determine_stage function
- Rework execute_stage function

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 30, 2024
- Delete da.yaml.j2; will remake in follow-up work
- Update fv3_warm.yaml.j2 to not use src/head variables

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 31, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 31, 2024
Also clean up unneeded python imports

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 31, 2024
Will add nest option in future task

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue May 31, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 3, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 3, 2024
- Add DO_NEST back into stage.py
- Add back in reworked yamls for fv3_warm and the nest

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 3, 2024
Add extra whitespaces in exglobal_stage_ic.py to address E231 error.

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 3, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 3, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 3, 2024
Improve readability of the stage yamls

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 5, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
Also add ICSDIR to config.base

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
Also update wave COM variable

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
- set job for gdas_half cycledef only
- update fcst jobs dependencies

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
- Delete the fill_ROTDIR functions used in half cycle setup;
functions are replaced by half cycle stage_ic jobs
- Update --icsdir setup flag to allow user provided path for all RUNs

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 14, 2024
* origin/develop:
  Add observation preparation job for aerosols DA to workflow (NOAA-EMC#2624)
  Remove ocean daily files (NOAA-EMC#2689)
  Update Jenkinsfile
  Add Hercules-EMC to the Jenkins configurable parameter list (NOAA-EMC#2685)
  Update gdas.cd and gsi_utils hashes (NOAA-EMC#2641)
  Add ability to use GEFS replay ICs (NOAA-EMC#2559)
  Replace `sleep` with `wait_for_file` (NOAA-EMC#2586)
  Add COM template for JEDI obs (NOAA-EMC#2678)
  Link both global-nest fix files and non-nest ones at the same time (NOAA-EMC#2632)
  Update ufs-weather-model  (NOAA-EMC#2663)
  Add ability to process ocean/ice products specific to GEFS (NOAA-EMC#2561)
  Update cleanup job to use COMIN/COMOUT (NOAA-EMC#2649)
  Add overwrite to creat experiment in BASH CI (NOAA-EMC#2676)
  Add handling to select CRTM cloud optical table based on cloud scheme and update calcanal_gfs.py  (NOAA-EMC#2645)

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 17, 2024
Makes yamls more generic and uses paths set previously

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 17, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 17, 2024
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 17, 2024
- Add new keys
- Remove determine function
- Update execute function to use single stage.yaml.j2

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 17, 2024
- Add RDATE and DTG_PREFIX
- Remove USE_OCN_PERTURB_FILES
- Always declare COM_ATMOS_ANALYSIS

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 20, 2024
- Convert COM variables to COMOUT variables
- Add mediator IC copy
- Add DTG_PREFIX to filename constructor
- Add replay updates

Refs NOAA-EMC#2475
KateFriedman-NOAA added a commit to KateFriedman-NOAA/global-workflow that referenced this issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants