-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to process ocean/ice products specific to GEFS #2561
Add ability to process ocean/ice products specific to GEFS #2561
Conversation
The config.base and gefs_tasks files have been modified so that ocean/ice GEFS hist files are 24-hour averages instead of 6-hour averages.
The ocean/ice_products yaml file has been modified so that 24-hour averaged products are post-processed instead of 6-hour averages.
The FHOUT_OCNICE_GFS variable has been added to the oceanice_products yaml file to allow for ocean/ice hist files of any time-averaged length to be inputted into the oceanice product program. Also, the yaml file has been updated so that the ocean/ice product netcdf files are saved for GEFS runs and grib2 files are saved for GFS runs.
A correction regarding the if statements have been added to the updated oceanice yaml file.
The original oceanice yaml file has been restored to a state prior to the changes related to GEFS.
A new oceanice_prod yaml file has been added for GEFS. The oceanice_prod config file for GEFS has been modified so that a GEFS-specific oceanice_prod yaml file is used.
A separate oceanice_prod config file has been added for GEFS.
cosvar: "cos_rot" | ||
angvar: "" | ||
{% if model_grid == 'mx025' or model_grid == 'mx050' or model_grid == 'mx100' %} | ||
ocean_levels: [5, 15, 25, 35, 45, 55, 65, 75, 85, 95, 105, 115, 125, 135, 145, 155, 165, 175, 185, 195, 205, 215, 225.86945, 241.06255, 266.5239, 308.7874, 373.9288, 467.3998, 593.87915, 757.1453, 959.97325, 1204.059, 1489.9735, 1817.1455, 2183.879, 2587.3995, 3023.9285, 3488.7875, 3976.524, 4481.0625] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricSinsky-NOAA, ocean_levels will need to round up to integer. Users of grib2 files reported that they have problems plotting decimal depths in grads and plot_data_plane. So, I'm going to update it for GFS. Please change it to:
ocean_levels: [5, 15, 25, 35, 45, 55, 65, 75, 85, 95, 105, 115, 125, 135, 145, 155, 165, 175, 185, 195, 205, 215, 226, 241, 267, 309, 374, 467, 594, 757, 960, 1204, 1490, 1817, 2184, 2587, 3024, 3489, 3977, 4481]
{% if model_grid == 'mx025' or model_grid == 'mx050' or model_grid == 'mx100' %} | ||
ocean_levels: [5, 15, 25, 35, 45, 55, 65, 75, 85, 95, 105, 115, 125, 135, 145, 155, 165, 175, 185, 195, 205, 215, 225.86945, 241.06255, 266.5239, 308.7874, 373.9288, 467.3998, 593.87915, 757.1453, 959.97325, 1204.059, 1489.9735, 1817.1455, 2183.879, 2587.3995, 3023.9285, 3488.7875, 3976.524, 4481.0625] | ||
{% elif model_grid == 'mx500' %} | ||
ocean_levels: [5, 15, 25, 35, 45, 55, 65, 75, 85, 95, 105, 115, 125, 135, 145, 155, 165, 175, 185, 195, 205, 215, 225.86945, 241.06255, 266.5239] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, please use:
ocean_levels: [5, 15, 25, 35, 45, 55, 65, 75, 85, 95, 105, 115, 125, 135, 145, 155, 165, 175, 185, 195, 205, 215, 226, 241, 267]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GwenChen-NOAA Thank you for letting me know about this issue regarding the decimal depths. I will make these changes to parm/post/oceanice_products_gefs.yaml
.
The oceanice_prod yaml file has been updated to fix an issue that users have encountered regarding plotting decimal depths. Decimal depths in the ocean_levels variable have been rounded up.
Do we really need to wait for #2559 for this? Seems independent. |
@WalterKolczynski-NOAA Waiting for PR #2559 is not required for this PR. However, further tests may be needed to make sure these changes are compatible with an f003 start. The current changes in this PR have been successfully tested with the EP5d ICs (f000 start). Should this PR be set to "ready for review", and then we can add any necessary changes in future PRs? |
Yes please. |
Marking this PR as ready for review. Some scripts may need to be modified when PR #2559 is merged, but these changes can be addressed in future PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditionally approved pending successful completion of CI tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
Automated global-workflow Testing Results:
|
Experiment C48_ATM_80858bca SUCCESS on Wcoss2 at 06/11/24 06:21:15 AM |
Experiment C48_S2SW_80858bca SUCCESS on Wcoss2 at 06/11/24 06:45:14 AM |
Experiment C96C48_hybatmDA_80858bca SUCCESS on Wcoss2 at 06/11/24 07:51:22 AM |
Experiment C96C48_ufs_hybatmDA_80858bca SUCCESS on Wcoss2 at 06/11/24 07:57:09 AM |
Experiment C96_atm3DVar_extended_80858bca SUCCESS on Wcoss2 at 06/11/24 01:42:31 PM |
All CI Test Cases Passed on Wcoss2:
Experiment C48_ATM_80858bca *** SUCCESS *** at 06/11/24 06:21:15 AM |
Connection to Hercules was lost from the controller after the build. |
@TerrenceMcGuinness-NOAA Hercules had an issue with a handful of nodes which have now been taken offline. This may or may not help the issue you are seeing. |
CI Passed Hercules at |
15eaf35
into
NOAA-EMC:develop
…bal-workflow into feature/move_jcb * 'feature/move_jcb' of https://github.com/danholdaway/global-workflow: Add COM template for JEDI obs (NOAA-EMC#2678) Link both global-nest fix files and non-nest ones at the same time (NOAA-EMC#2632) Update ufs-weather-model (NOAA-EMC#2663) Add ability to process ocean/ice products specific to GEFS (NOAA-EMC#2561) Update cleanup job to use COMIN/COMOUT (NOAA-EMC#2649) Add overwrite to creat experiment in BASH CI (NOAA-EMC#2676) Add handling to select CRTM cloud optical table based on cloud scheme and update calcanal_gfs.py (NOAA-EMC#2645) Update RDHPCS Hera resource for `eupd` task (NOAA-EMC#2636)
* origin/develop: Add observation preparation job for aerosols DA to workflow (NOAA-EMC#2624) Remove ocean daily files (NOAA-EMC#2689) Update Jenkinsfile Add Hercules-EMC to the Jenkins configurable parameter list (NOAA-EMC#2685) Update gdas.cd and gsi_utils hashes (NOAA-EMC#2641) Add ability to use GEFS replay ICs (NOAA-EMC#2559) Replace `sleep` with `wait_for_file` (NOAA-EMC#2586) Add COM template for JEDI obs (NOAA-EMC#2678) Link both global-nest fix files and non-nest ones at the same time (NOAA-EMC#2632) Update ufs-weather-model (NOAA-EMC#2663) Add ability to process ocean/ice products specific to GEFS (NOAA-EMC#2561) Update cleanup job to use COMIN/COMOUT (NOAA-EMC#2649) Add overwrite to creat experiment in BASH CI (NOAA-EMC#2676) Add handling to select CRTM cloud optical table based on cloud scheme and update calcanal_gfs.py (NOAA-EMC#2645) Refs NOAA-EMC#2475
@@ -0,0 +1,38 @@ | |||
#! /usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricSinsky-NOAA
I just noticed this script was added after an approval review was made on this PR and it slipped from being reviewed.
The function implemented here is the datadep
with age
that Rocoto already provides.
Besides, this is completely hardwired for GEFS options.
The function is checking the age of a file.
The file happens to be a ice netcdf file.
We will need to implement this via the proper rocoto means of checking if a file exists and if it has been present for 2 mins.
Description
This PR begins to add the capability to produce GEFSv13 ocean and ice products in the global-workflow according to stakeholder requirements. The following features are added.
FHOUT_OCNICE
has been split into two variables calledFHOUT_OCN
andFHOUT_ICE
. The same has been done forFHOUT_OCNICE_GFS
.Refs #1878
Type of change
Change characteristics
How has this been tested?
These changes have been tested using the EP5d ICs on WCOSS2. Additional testing will be performed using the replay ICs from the changes in PR #2559.
Checklist