JEDI based Marine DA tasks #1134

guillaumevernieres · 2022-11-23T19:54:14Z

Description
This PR adds the relevant scripts/steps to exercise the JEDI based marine DA eventually needed for GFSv17. See issue #1072 for more details.

The branch used for this PR was extracted from a "rogue" branch that included changes to the model related scripts to allow for WCDA cycling. The testing was done with the coupled C48/5deg atmos/ocean model, using the GSI for the amos initialization and the JEDI based marine DA system (SOCA) for the ocean initialization.

It is probably step 1 of at least 2 steps to get this work to a functional state in develop. I just don't know yet who's responsibility it is to fix the coupled model scripting to make it work in cycled mode.

fixes issue JEDI-based marine DA tasks #1072 (being perhaps a bit generous on my work accomplishment here ...)

A few notes:

Copying some of the SOCA fixed files has yet to be coordinated: An environment variable in config.ocnanal is pointing to /scratch2/NCEPDEV/ocean/Guillaume.Vernieres/data/static/72x35x25/. This needs to be copied elsewhere.
This work as is does not cycle and will require more work on the model side as pointed above
The testing of that "rogue" branch from which this PR is derived, was only done on Hera.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes need updates to the documentation. I have made corresponding changes to the documentation
My changes generate no new warnings
New and existing tests pass with my changes
Any dependent changes have been merged and published

guillaumevernieres · 2022-11-28T13:53:50Z

@aerorahul ,@WalterKolczynski-NOAA , @KateFriedman-NOAA :

The linter complaints seem to be outside of my code changes, do I need to address the issues?
I don't have the necessary permissions to add reviewers, could that be changed?

aerorahul · 2022-11-28T14:40:11Z

sorc/link_workflow.sh

+  declare -a JEDI_EXE=("fv3jedi_addincrement.x" \
+                       "fv3jedi_diffstates.x" \
+                       "fv3jedi_ensvariance.x" \
+                       "fv3jedi_hofx.x" \
+                       "fv3jedi_var.x" \
+                       "fv3jedi_convertincrement.x" \
+                       "fv3jedi_dirac.x" \
+                       "fv3jedi_error_covariance_training.x" \
+                       "fv3jedi_letkf.x" \
+                       "fv3jedi_convertstate.x" \
+                       "fv3jedi_eda.x" \
+                       "fv3jedi_forecast.x" \
+                       "fv3jedi_plot_field.x" \
+                       "fv3jedi_data_checker.py" \
+                       "fv3jedi_enshofx.x" \
+                       "fv3jedi_hofx_nomodel.x" \
+                       "fv3jedi_testdata_downloader.py" )
+            JEDI_EXE+=("soca_addincrement.x" \
+                        "soca_enspert.x" \
+                        "soca_hofx.x" \
+                        "soca_ensrecenter.x" \
+                        "soca_convertincrement.x" \
+                        "soca_ensvariance.x" \
+                        "soca_letkf.x" \
+                        "soca_convertstate.x" \
+                        "soca_error_covariance_training.x" \
+                        "soca_setcorscales.x" \
+                        "soca_diffstates.x" \
+                        "soca_forecast.x" \
+                        "soca_sqrtvertloc.x" \
+                        "soca_dirac.x" \
+                        "soca_gridgen.x" \
+                        "soca_staticbinit.x" \
+                        "soca_enshofx.x" \
+                        "soca_hofx3d.x" \
+                        "soca_var.x")


Are all of these executables used in the workflow?

@aerorahul , no, only a fraction are used currently but I'm also realizing that some of these will probably never be used. Should I minimize that list to what will eventually be used or to what's currently used?

yes. We should only link to what we are actively using. There are other EE2 requirements for how they are built and the source code is linked, but I don't have an idea on how to address that issue. For e.g.gsi.x comes from a directory gsi.fd

Yes this is something that we are going to have to work out with NCO, because it probably will be unreasonable to modify JEDI to put every single executable in its own folder when this is seemingly purely an aesthetic choice

aerorahul

Changes look good.
A few comments and a review from the other JEDI developers would be helpful.

aerorahul · 2022-11-28T14:49:43Z

workflow/rocoto/workflow_tasks.py

+        if self.app_config.do_jediocnvar:
+            dep_dict = {'type': 'task', 'name': f'{self.cdump}ocnanalrun'}
+            dep = rocoto.add_dependency(dep_dict)
+            dependencies = rocoto.create_dependency(dep=dep)
+


Does gldas really need to wait for ocean analysis jobs?

rather instead the fcst needs to wait for ocnanal

@aerorahul : What @CoryMartin-NOAA said, forecast waiting for ocnanalrun.

yes. I understand that dependency (ocnanalrun to complete for fcst to start). Not sure this is going to be the case if gldas is turned off.

aerorahul · 2022-11-28T14:50:06Z

workflow/rocoto/workflow_tasks.py

+        deps.append(rocoto.add_dependency(dep_dict))
+        dependencies = rocoto.create_dependency(dep=deps)
+
+        cycledef = self.cdump


Don't think you need this. The default for cycledef = cdump

workflow/rocoto/workflow_tasks.py

aerorahul · 2022-11-28T14:52:46Z

parm/config/config.ocnanal

+export R2D2_OBS_DUMP=s2s_v1
+export R2D2_OBS_SRC=gdas_marine
+export R2D2_OBS_WINDOW=24     # TODO: Check if the R2D2 sampling DB window is still needed
+export COMIN_OBS=/scratch2/NCEPDEV/marineda/r2d2


Perhaps add a TODO here to remind us to move this to a common space.

@aerorahul : A common space for R2D2 stuff or for the entirety of config.ocnanal?

aerorahul · 2022-11-28T14:53:43Z

parm/config/config.ocnanal

@@ -0,0 +1,23 @@
+#!/bin/bash -x


I don't think we need a -x here.

CoryMartin-NOAA

A few comments, mostly looks good to me

CoryMartin-NOAA · 2022-11-28T15:48:17Z

jobs/rocoto/ocnanalpost.sh

+# Source GDASApp modules
+module purge
+module use "${HOMEgfs}"/sorc/gdas.cd/modulefiles
+module load GDAS/hera


This shouldn't be machine dependent here.

CoryMartin-NOAA · 2022-11-28T15:48:28Z

jobs/rocoto/ocnanalprep.sh

+# Source GDASApp modules
+module purge
+module use "${HOMEgfs}"/sorc/gdas.cd/modulefiles
+module load GDAS/hera


same comment

CoryMartin-NOAA · 2022-11-28T15:48:33Z

jobs/rocoto/ocnanalrun.sh

+# Source GDASApp modules
+module purge
+module use "${HOMEgfs}"/sorc/gdas.cd/modulefiles
+module load GDAS/hera


CoryMartin-NOAA · 2022-11-28T15:49:58Z

parm/config/config.resources

+        npes=16
+        ;;
+      *)
+          echo "FATAL: Resolution not supported'"


This will be a problem eventually but fine for now

CoryMartin-NOAA · 2022-11-28T15:51:22Z

workflow/rocoto/workflow_tasks.py

+        if self.app_config.do_jediocnvar:
+            dep_dict = {'type': 'task', 'name': f'{self.cdump}ocnanalrun'}
+            dep = rocoto.add_dependency(dep_dict)
+            dependencies = rocoto.create_dependency(dep=dep)
+


rather instead the fcst needs to wait for ocnanal

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

jobs/rocoto/ocnanalpost.sh

jobs/rocoto/ocnanalprep.sh

jobs/rocoto/ocnanalrun.sh

guillaumevernieres · 2022-11-28T18:36:58Z

Thanks for your reviews/suggested commits @aerorahul and @CoryMartin-NOAA . I've addressed your comments and merged your suggestions.

jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_POST

aerorahul · 2022-11-28T18:56:04Z

jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN

+
+# Prepare soca static dir
+
+ln -s "${COMOUT}"/analysis/* .


Why is this in a j-job? @CoryMartin-NOAA

Thanks for putting the burden of explaining what I did on @CoryMartin-NOAA ! So, Cory, what's up with that?

@aerorahul I remember what the issue was. All the yaml's , static files, backgrounds, obs, etc ... are created/linked/copied in the "prep" step under ${COMOUT}"/analysis/ and the content of that directory is needed by the run step.

@guillaumevernieres follow what I have here for the aero case:

export DATA=${DATA:-${DATAROOT}/aeroanl_${CDATE}} mkdir -p "${DATA}" cd "${DATA}" || (echo "${DATA} does not exist. ABORT!"; exit 1)

global-workflow/jobs/JGDAS_GLOBAL_AERO_ANALYSIS_FINALIZE

Lines 48 to 50 in 1536029

export DATA=${DATA:-${DATAROOT}/aeroanl_${CDATE}}

mkdir -p "${DATA}"

cd "${DATA}" || (echo "${DATA} does not exist. ABORT!"; exit 1)

guillaumevernieres · 2022-11-29T16:28:47Z

@aerorahul , @CoryMartin-NOAA , I just pushed a commit that addresses most of your comments except that I'm still not doing anything in post. I'll have a separate PR that will populate post if it's OK with you.

aerorahul · 2022-11-29T16:54:37Z

jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP

+cd "${DATAROOT}" || exit 1
+[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}"


if you remove this here, you won't be able to use it in the ocnanalrun job.
I think you need to keep this.

Oops, thanks ... I just removed these lines.

CoryMartin-NOAA

one todo for me, one thing that needs fixed by @guillaumevernieres

CoryMartin-NOAA · 2022-11-29T17:06:57Z

jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN

+# Remove the Temporary working directory
+##########################################
+cd "${DATAROOT}" || exit 1
+[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}"


Don't want this one either I don't think unless you have nothing to archive/save from this job back to the ROTDIR.

@CoryMartin-NOAA , unless I messed up (very likely), the analysis and increment are dumped in COMOUT (==ROTDIR?) ... And as I write this, I realize I forgot to do the same for diag. Is it OK to have symlinks to directories in COMOUT/ROTDIR in which we directly write what we want to keep?

for now it is, but 'eventually' it is not. NCO wants no symlinks, and it makes sense from a solid state drive for run / spinning disk for storage perspective. What my plan is/was for the aerosol tasks (see PR#1106) is to copy everything I want to save from $DATA to $COMOUT as part of the finalize job after the run job.

Sounds good @CoryMartin-NOAA , I'll do this in a subsequent PR if that's OK with you (I'm just being polite and respectful in exchange for a green check). My next step is to reconcile my cycling branch with the changes here and make it work again, which I'm pretty sure will require some adjustment/bug fixes in the GDASApp and the g-w. Looking forward to it!

CoryMartin-NOAA · 2022-11-29T17:08:04Z

sorc/link_workflow.sh

+                       "fv3jedi_data_checker.py" \
+                       "fv3jedi_enshofx.x" \
+                       "fv3jedi_hofx_nomodel.x" \
+                       "fv3jedi_testdata_downloader.py" )


Note to myself and @RussTreadon-NOAA we will also want to prune this list for fv3jedi executables at a later date

CoryMartin-NOAA

Approved pending conflict resolutions

env/HERA.env

@@ -87,6 +87,16 @@
    [[ ${NTHREADS_AEROANL} -gt ${nth_max} ]] && export NTHREADS_AEROANL=${nth_max}
    export APRUN_AEROANL="${launcher} -n ${npe_aeroanlrun}"

+elif [ $step = "ocnanalrun" ]; then


env/ORION.env

@@ -86,6 +86,16 @@
    [[ ${NTHREADS_AEROANL} -gt ${nth_max} ]] && export NTHREADS_AEROANL=${nth_max}
    export APRUN_AEROANL="${launcher} -n ${npe_aeroanlrun}"

+elif [ $step = "ocnanalrun" ]; then


env/ORION.env

@@ -86,6 +86,16 @@
    [[ ${NTHREADS_AEROANL} -gt ${nth_max} ]] && export NTHREADS_AEROANL=${nth_max}
    export APRUN_AEROANL="${launcher} -n ${npe_aeroanlrun}"

+elif [ $step = "ocnanalrun" ]; then


env/HERA.env

env/ORION.env

WalterKolczynski-NOAA

Develop has been updated to eliminate all of the existing shellcheck issues in the *.env files, so this PR will need to address all those present in the new code as well.

jobs/rocoto/ocnanalpost.sh

jobs/rocoto/ocnanalprep.sh

jobs/rocoto/ocnanalrun.sh

parm/config/config.ocnanalprep

parm/config/config.ocnanalrun

parm/config/config.ocnanalpost

sorc/link_workflow.sh

guillaumevernieres · 2022-12-06T00:33:45Z

Thanks for your review @WalterKolczynski-NOAA , I've addressed your comments.

The new marine DA jobs were added (PR #1134) roughly concurrently with the refactoring of the j-job scripts (PR #1120), and thus didn't pick up the changes there. These new jobs are now updated.

* develop: Correct issue in linking final restart files (NOAA-EMC#1285) Remove execute permissions from config files (NOAA-EMC#1281) Make needed updates to run forecast from GEFS (NOAA-EMC#1203) Remove unnecessary variables which reference to nemsio (NOAA-EMC#1259) Create analysis files for early-cycle EnKF by default (NOAA-EMC#1237) Don't wipe $DATA before running ocean bmat (NOAA-EMC#1280) More marine DA j-jobs (NOAA-EMC#1270) Update UFS-DA atmospheric prep script to be consistent with GDASApp update (NOAA-EMC#1265) Add new jjob for ocean analysis bmat (NOAA-EMC#1239) Retire ecf/versions in develop (NOAA-EMC#1267) Deploy documentation to RTD (NOAA-EMC#1264) Temporarily disable failing pytest (NOAA-EMC#1263) Remove incorrect/misleading comments in config.base (NOAA-EMC#1261) Add initial Sphinx documentation (NOAA-EMC#1258) Remove nemsio support (NOAA-EMC#1255) Increase wallclock for diag jobs (NOAA-EMC#1216) Use correct resources for GFS gempak (NOAA-EMC#1214) Abstract common j-job tasks (NOAA-EMC#1230) Add missing mkgfsawps.x link (NOAA-EMC#1218) Fix post sounding job (NOAA-EMC#1212) Revert "Use fracoro data for all new UFS applications (NOAA-EMC#1182)" (NOAA-EMC#1240) Use fracoro data for all new UFS applications (NOAA-EMC#1182) Revert "Merge GFS v16.3 operational GSI changes into develop branch. (NOAA-EMC#1158)" (NOAA-EMC#1238) Add more user defined parameters for the marine DA (NOAA-EMC#1235) Update pytests action version and run sequentially (NOAA-EMC#1236) Add utility to compare Fortran namelists (NOAA-EMC#1234) Updates for pygw (NOAA-EMC#1231) Merge GFS v16.3 operational GSI changes into develop branch. (NOAA-EMC#1158) Move member up in directory hierarchy (NOAA-EMC#1201) Enable staging ics for cycled experiments. (NOAA-EMC#1199) Add tests for configuration.py (NOAA-EMC#1192) Replace ocnanal_${CDATE}} with ${RUN}ocnanal_${cyc} (NOAA-EMC#1191) define NET and RUN in the Rocoto XML to accurately mimic the ecf in ecflow (NOAA-EMC#1193) Fix checking for restart files (NOAA-EMC#1186) Fix 'DEBUG' option in build_ufs.sh (NOAA-EMC#1188) Update archive job memory request value for R&Ds (NOAA-EMC#1183) Reorder post so all flux files are generated when running offline (NOAA-EMC#1181) Stop checking for restarts on non-GFS CDUMPs (NOAA-EMC#1179) Add missing jobids in some pre-job scripts (NOAA-EMC#1176) Remove existing directory if it exists when getic runs (NOAA-EMC#1165) Add logging decorator, test and test for yaml_file (NOAA-EMC#1178) fix coding norm check in `hosts.py` (NOAA-EMC#1174) Fix some bugs and make other changes so ctest in GDASApp works (NOAA-EMC#1172) Support for the GDASApp testing in containers (NOAA-EMC#1151) ATM 3DVAR with and without IAU (NOAA-EMC#1113) Enable checking for python norms and fix violating code (NOAA-EMC#1168) Enforce decimal math in atmos post (NOAA-EMC#1171) Update marine DA j-jobs to new format (NOAA-EMC#1149) Add utility to manipulate files en masse (NOAA-EMC#1166) add action to run pytests (NOAA-EMC#1167) Pin `differential-shellcheck` to `v3` tag (NOAA-EMC#1162) Add a task base class and basic logger (NOAA-EMC#1160) Recursively convert dict to AttrDict when making an AttrDict (NOAA-EMC#1154) move configuration.py to pygw. Use it from there. return AttrDict after sourcing configs (NOAA-EMC#1153) JEDI based Marine DA tasks (NOAA-EMC#1134) Allow customizations based on user/configuration (NOAA-EMC#1146) First step towards making j-jobs consistent in use from ecflow and rocoto (NOAA-EMC#1120) enable APP=S2SWA on WCOSS2 (NOAA-EMC#1142) Fix typo in .shellcheckrc Remove prod_envir module load from WCOSS2 (NOAA-EMC#1138) Link staged GSI fix files instead of cloning them from gerrit (NOAA-EMC#1132) Address shellcheck warnings in env files (NOAA-EMC#1136) Adds group size and nmem for GEFS (NOAA-EMC#1127) Remove unnecessary sCDATE assignment in forecast_predet.sh (NOAA-EMC#1133) Convert archive jobs to proper j-jobs (NOAA-EMC#1115) Update C48 forecast to run with one thread (NOAA-EMC#1131) Improved error messages from atmos analysis (NOAA-EMC#1125) Update MODULEPATH for Orion (NOAA-EMC#1126) MPMD variable updates and fix (NOAA-EMC#1124) Introduce FHMAX_ENKF_GFS to extending ensemble forecast capabilities (NOAA-EMC#1122) Update R&D launcher commands for tasks and multi-prog (NOAA-EMC#1112) Correct crtm path in UFS DA atmospheric analysis scripts (NOAA-EMC#1111) Correct syntax in remaining sorc scripts (NOAA-EMC#1105) Add GSI background error covariance as an option for UFS DA variational assimilation (NOAA-EMC#1104) Add Early Cycle EnKF workflow (NOAA-EMC#1022) Correct errors with gdas and monitoring symlinks (NOAA-EMC#1101) Fixed gfs-utils links (NOAA-EMC#1099) Fix build scripts and bring into compliance (NOAA-EMC#1096) Feature/updates for gdas app (NOAA-EMC#1091) Change GLDAS USE_CFP to NO on Hera (NOAA-EMC#1094) Resource updates to support WCOSS2 (NOAA-EMC#1070) Set COMPILER in link for detect machine (NOAA-EMC#1092) gfs utils update (NOAA-EMC#1088) GFS-UTILS update for build and ush scripts (NOAA-EMC#1082) Update UFS version to 2022 Oct 19 (NOAA-EMC#1083) Use more cycledefs for task control (NOAA-EMC#1078) removing superfluous EFSOI-specific files from develop (NOAA-EMC#1079) Update UFS to Sept 9 version (NOAA-EMC#1073) Modify default file location for monitor data when using rocoto (NOAA-EMC#1065) Fix companion ocean resolution for C48 (NOAA-EMC#1066) Add trailing slash for gldas topo path (NOAA-EMC#1064) Limit number of CPU for post (NOAA-EMC#1061) Fix eupd trace (NOAA-EMC#1057) Port to S4 (NOAA-EMC#1023) Update to obsproc.v1.0.2 and prepobs.v1.0.1 (NOAA-EMC#1049) Add GDAS to the partial build list (NOAA-EMC#1050) Fix group number being treated as octal in gdas arch (NOAA-EMC#1053) Remove trace from link script (NOAA-EMC#1046) Update gfs-utils hash to 3a609ea (NOAA-EMC#1048) Fix link script usage statement (NOAA-EMC#1045) Replace preamble variable commands with functions (NOAA-EMC#1012) Implement fix reorg and remove gfs-utils code (NOAA-EMC#1009) Rename post scripts (NOAA-EMC#1038) Fix missing @ symbol with COMINsyn in config.base (NOAA-EMC#1039) WCOSS2 run support and script/config updates (NOAA-EMC#1030) Remove base_svn from Hera and Orion hosts files (NOAA-EMC#1036) initial commit for incoming yaml work (NOAA-EMC#1029) Fix radiance verification failing to find diag files (NOAA-EMC#1031) Supported resolutions on platforms and defaults for mode (NOAA-EMC#1026) Add GLDAS scripts & fix GLDAS job (NOAA-EMC#1018) Update GSI Monitor for radmon fix Correct shell linter config (NOAA-EMC#1013) Correct diagnostic file handling in ush/ozn_xtrct.sh (NOAA-EMC#1016) Add shell linter Github action for pull requests (NOAA-EMC#1007) Build updates for WCOSS2 (NOAA-EMC#1002) Update UFS_UTILS tag to `ufs_utils_1_8_0` (NOAA-EMC#1001) Fix preamble id (NOAA-EMC#996) Add missing "atmos" into job dependencies (NOAA-EMC#998) Bugfix in arch.sh to remove hardwired "htar" (NOAA-EMC#992) Add in stubs for aerosol DA tasks + bugfix for setup_expt where cycled and ATMA are used (NOAA-EMC#990) Add GSI monitor scripts (NOAA-EMC#969) Fix product generation at some fcst hrs (NOAA-EMC#988) Add initial config files for global aerosol DA (NOAA-EMC#986) Update diag table to remove wav-ocn coupling fields (NOAA-EMC#979) use a robust Findwgrib2.cmake to find wgrib2 built w/ native wgrib2 build (NOAA-EMC#970) Externals.cfg was stale and had drifted off (NOAA-EMC#965) Fix post comparison with zero-padded numbers (NOAA-EMC#964)

added marine da

30a115f

guillaumevernieres changed the title ~~added marine da~~ JEDI based Marine DA tasks Nov 23, 2022

WalterKolczynski-NOAA requested review from WalterKolczynski-NOAA and aerorahul November 28, 2022 13:58

WalterKolczynski-NOAA self-assigned this Nov 28, 2022

WalterKolczynski-NOAA added the feature New feature or request label Nov 28, 2022

aerorahul requested review from RussTreadon-NOAA and CoryMartin-NOAA November 28, 2022 14:29

aerorahul reviewed Nov 28, 2022

View reviewed changes

aerorahul approved these changes Nov 28, 2022

View reviewed changes

CoryMartin-NOAA reviewed Nov 28, 2022

View reviewed changes

guillaumevernieres and others added 3 commits November 28, 2022 13:23

Update workflow/rocoto/workflow_tasks.py

79abe63

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

Update workflow/rocoto/workflow_tasks.py

6e0a88f

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>

addressed reviewer's comments

56a6a70

guillaumevernieres requested review from CoryMartin-NOAA and aerorahul and removed request for RussTreadon-NOAA, WalterKolczynski-NOAA, CoryMartin-NOAA and aerorahul November 28, 2022 18:31

github-advanced-security bot found potential problems Nov 28, 2022

View reviewed changes

jobs/rocoto/ocnanalpost.sh Fixed Show fixed Hide fixed

jobs/rocoto/ocnanalprep.sh Fixed Show fixed Hide fixed

jobs/rocoto/ocnanalrun.sh Fixed Show fixed Hide fixed

cn

6094916

guillaumevernieres marked this pull request as ready for review November 28, 2022 18:35

aerorahul reviewed Nov 28, 2022

View reviewed changes

jobs/JGDAS_GLOBAL_OCEAN_ANALYSIS_POST Show resolved Hide resolved

aerorahul reviewed Nov 28, 2022

View reviewed changes

guillaumevernieres mentioned this pull request Nov 29, 2022

Reorganization of the marine DA scratch dir NOAA-EMC/GDASApp#209

Closed

prep/run in same scratch

dc01e4f

aerorahul reviewed Nov 29, 2022

View reviewed changes

keep DATA for run step

8458a39

CoryMartin-NOAA reviewed Nov 29, 2022

View reviewed changes

CoryMartin-NOAA approved these changes Nov 29, 2022

View reviewed changes

Merge branch 'develop' into feature/marine_gdas

07edfd6

github-advanced-security bot found potential problems Nov 29, 2022

View reviewed changes

guillaumevernieres requested a review from RussTreadon-NOAA November 30, 2022 13:45

WalterKolczynski-NOAA requested changes Nov 30, 2022

View reviewed changes

tidy code according to rev comments

95adc6e

guillaumevernieres requested a review from WalterKolczynski-NOAA December 6, 2022 00:26

WalterKolczynski-NOAA approved these changes Dec 6, 2022

View reviewed changes

WalterKolczynski-NOAA merged commit c961e9a into NOAA-EMC:develop Dec 6, 2022

aerorahul mentioned this pull request Dec 6, 2022

Update marine DA j-jobs to new format #1149

Merged

7 tasks

guillaumevernieres mentioned this pull request Dec 9, 2022

I know this is how shellcheck "fixes" it, but it is preferred to quote the entire path. (Several more in this file not noted.) #1163

Closed

guillaumevernieres deleted the feature/marine_gdas branch March 27, 2023 13:18

	export DATA=${DATA:-${DATAROOT}/aeroanl_${CDATE}}
	mkdir -p "${DATA}"
	cd "${DATA}" \|\| (echo "${DATA} does not exist. ABORT!"; exit 1)

		cd "${DATAROOT}" \|\| exit 1
		[[ ${KEEPDATA} = "NO" ]] && rm -rf "${DATA}"

JEDI based Marine DA tasks #1134

JEDI based Marine DA tasks #1134

Conversation

guillaumevernieres commented Nov 23, 2022 • edited Loading

A few notes:

guillaumevernieres commented Nov 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerorahul Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aerorahul left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guillaumevernieres commented Nov 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CoryMartin-NOAA Nov 28, 2022 • edited Loading

Choose a reason for hiding this comment

guillaumevernieres commented Nov 29, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

guillaumevernieres commented Dec 6, 2022

guillaumevernieres commented Nov 23, 2022 •

edited

Loading

aerorahul Nov 28, 2022 •

edited

Loading

CoryMartin-NOAA Nov 28, 2022 •

edited

Loading