Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C768 and C1152 S2SW test cases #2509

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add C768 and C1152 S2SW test cases #2509

merged 2 commits into from
Apr 19, 2024

Conversation

JessicaMeixner-NOAA
Copy link
Contributor

@JessicaMeixner-NOAA JessicaMeixner-NOAA commented Apr 19, 2024 •
edited
Loading

Description

Adds two yaml files for testing free-forecast S2SW at either C768 or C1152. ICs are on WCOSS2, Orion and Hera.

Resolves #2502

To use one of these yaml files for example:
pslot=PSLOT RUNTESTS=Your/RunTest/Dir SLURM_ACCOUNT=some-cpu ./../global-workflow/workflow/create_experiment.py --yaml ../global-workflow/ci/cases/weekly/C768_S2SW.yaml

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

Created xmls for both tests on her and ran through init jobs. Needs updates from another PR to run forecast on hera.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

aerorahul
aerorahul approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
My only request is to place them under ci/cases/hires and not under ci/cases/pr so that they don't get triggered automatically with every PR.

@JessicaMeixner-NOAA
Copy link
Contributor Author

@aerorahul I thought the weekly would be sufficient to achieve that. I'll create the new hires directory and move them there.

@aerorahul
Copy link
Contributor

@KateFriedman-NOAA @WalterKolczynski-NOAA
Can we make sure the IC dataset for these tests are part of regular sync between the machines?

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title add C768 and C1152 S2SW ci yamls Add C768 and C1152 S2SW test cases Apr 19, 2024
@WalterKolczynski-NOAA
Copy link
Contributor

WalterKolczynski-NOAA commented Apr 19, 2024 •
edited
Loading

@KateFriedman-NOAA @WalterKolczynski-NOAA Can we make sure the IC dataset for these tests are part of regular sync between the machines?

They're part of the HR3 ICs. They're on the three tier-1 machines for sure. We're pointing to other people's copies.

@aerorahul aerorahul merged commit e4a552e into NOAA-EMC:develop Apr 19, 2024
4 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 23, 2024
@danholdaway
Merge remote-tracking branch 'upstream/develop' into feature/use_jcb_atm
0a920cd 
* upstream/develop:
  Add CCPP suite and FASTER option to UFS build (NOAA-EMC#2521)
  New "atmanlfv3inc" Rocoto job (NOAA-EMC#2420)
  Hotfix to disable STALLED in CI as an error (NOAA-EMC#2523)
  Add restart on failure capability for the forecast executable (NOAA-EMC#2510)
  Update parm/transfer list files to match vetted GFSv16 set (NOAA-EMC#2517)
  Update gdas_gsibec_ver to 20240416 (NOAA-EMC#2497)
  Adding more cycles to gempak script gfs_meta_sa2.sh (NOAA-EMC#2518)
  Update gsi_enkf.sh hash to 457510c (NOAA-EMC#2514)
  Enable using the FV3_global_nest_v1 CCPP suite (NOAA-EMC#2512)
  CI Refactoring and STALLED case detection (NOAA-EMC#2488)
  Add C768 and C1152 S2SW test cases (NOAA-EMC#2509)
  Fix paths for refactored prepocnobs task (NOAA-EMC#2504)
@JessicaMeixner-NOAA JessicaMeixner-NOAA deleted the feature/addcihr branch May 9, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add yaml to CI for high resolution tests to enable easy testing
3 participants
@JessicaMeixner-NOAA @aerorahul @WalterKolczynski-NOAA