Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsi_enkf.sh hash to 457510c #2514

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Apr 22, 2024

Description

The gsi_enkf.fd hash is updated to bring in revisions to GSI source code file src/gsi/correlated_obsmod.F90. The order in which set up checks are performed have been modified to allow gsi.x to successfully run retrospective GFS v17 cases with correlated error active.

Resolves #2507

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO. This PR does not change an existing functionality. Instead it restores a broken functionality.
  • Does this change require a documentation update? NO

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Apr 22, 2024
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aerorahul aerorahul added the CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS label Apr 22, 2024
@RussTreadon-NOAA
Copy link
Contributor Author

@CatherineThomas-NOAA and @JessicaMeixner-NOAA - the GSI hash at which this PR points at resolves the correlated error problem documented in #2507. Can either of you review the changes?

@WalterKolczynski-NOAA and @KateFriedman-NOAA - this PR updates the gsi_enkf.fd hash to bring in a revised gsi.x which can run retrospective GFS v17 cases. The PR needs to be merged into g-w develop for use in GFS v17 retrospective parallels.

@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Apr 22, 2024
@emcbot
Copy link

emcbot commented Apr 22, 2024

CI Update on Wcoss2 at 04/22/24 01:45:07 PM
============================================
Cloning and Building global-workflow PR: 2514
with PID: 115828 on host: dlogin08

@JessicaMeixner-NOAA
Copy link
Contributor

@RussTreadon-NOAA I will test to see if I get past the previous failure I had. Thank you for making these fixes!

@RussTreadon-NOAA
Copy link
Contributor Author

Thank you @JessicaMeixner-NOAA

@TerrenceMcGuinness-NOAA
Copy link
Collaborator

The CI on WCOSS had just been updated this morning midstream of this PR getting started. I am going to revert the label to Ready so it can restart with these updates. Shouldn't take too long since CI runs are quicker on WCOSS.

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Apr 22, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Apr 22, 2024
@NOAA-EMC NOAA-EMC deleted a comment from emcbot Apr 22, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS and removed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed labels Apr 22, 2024
@NOAA-EMC NOAA-EMC deleted a comment from emcbot Apr 22, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Apr 22, 2024
@NOAA-EMC NOAA-EMC deleted a comment from emcbot Apr 22, 2024
@NOAA-EMC NOAA-EMC deleted a comment from emcbot Apr 22, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS and removed CI-Wcoss2-Failed **Bot use only** CI testing on WCOSS for this PR has failed labels Apr 22, 2024
@emcbot emcbot added CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS and removed CI-Wcoss2-Ready **CM use only** PR is ready for CI testing on WCOSS labels Apr 22, 2024
@emcbot
Copy link

emcbot commented Apr 22, 2024

CI Update on Wcoss2 at 04/22/24 02:45:11 PM
============================================
Cloning and Building global-workflow PR: 2514
with PID: 98682 on host: dlogin08

@NOAA-EMC NOAA-EMC deleted a comment from emcbot Apr 22, 2024
@emcbot emcbot added CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building **Bot use only** CI testing is cloning/building on WCOSS labels Apr 22, 2024
@emcbot
Copy link

emcbot commented Apr 22, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Mon Apr 22 14:49:24 UTC 2024 on dlogin08
---------------------------------------------------
Build: Completed at 04/22/24 03:00:40 PM
Case setup: Completed for experiment C48_ATM_a641f7bb
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_a641f7bb
Case setup: Skipped for experiment C48_S2SWA_gefs_a641f7bb
Case setup: Completed for experiment C48_S2SW_a641f7bb
Case setup: Completed for experiment C96_atm3DVar_a641f7bb
Case setup: Skipped for experiment C96_atmaerosnowDA_a641f7bb
Case setup: Completed for experiment C96C48_hybatmDA_a641f7bb
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_a641f7bb

@JessicaMeixner-NOAA
Copy link
Contributor

@RussTreadon-NOAA I can confirm that my previously failed gdasanal job succeeded when I pointed to the hash from this PR!

@RussTreadon-NOAA
Copy link
Contributor Author

Excellent! Thank you @JessicaMeixner-NOAA for running this test.

@emcbot
Copy link

emcbot commented Apr 22, 2024

Experiment C48_ATM_a641f7bb SUCCESS on Wcoss2 at 04/22/24 04:32:14 PM

@emcbot
Copy link

emcbot commented Apr 22, 2024

Experiment C96_atm3DVar_a641f7bb SUCCESS on Wcoss2 at 04/22/24 05:24:16 PM

@emcbot
Copy link

emcbot commented Apr 22, 2024

Experiment C96C48_hybatmDA_a641f7bb SUCCESS on Wcoss2 at 04/22/24 05:24:24 PM

@emcbot
Copy link

emcbot commented Apr 22, 2024

Experiment C48_S2SW_a641f7bb SUCCESS on Wcoss2 at 04/22/24 05:32:17 PM

@emcbot
Copy link

emcbot commented Apr 22, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_a641f7bb *** SUCCESS *** at 04/22/24 04:32:14 PM
Experiment C96_atm3DVar_a641f7bb *** SUCCESS *** at 04/22/24 05:24:16 PM
Experiment C96C48_hybatmDA_a641f7bb *** SUCCESS *** at 04/22/24 05:24:24 PM
Experiment C48_S2SW_a641f7bb *** SUCCESS *** at 04/22/24 05:32:17 PM

@emcbot emcbot added CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running **Bot use only** CI testing on WCOSS for this PR is in-progress labels Apr 22, 2024
@aerorahul aerorahul merged commit d839a68 into NOAA-EMC:develop Apr 22, 2024
4 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/gsihash branch April 22, 2024 17:38
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 23, 2024
* upstream/develop:
  Add CCPP suite and FASTER option to UFS build (NOAA-EMC#2521)
  New "atmanlfv3inc" Rocoto job (NOAA-EMC#2420)
  Hotfix to disable STALLED in CI as an error (NOAA-EMC#2523)
  Add restart on failure capability for the forecast executable (NOAA-EMC#2510)
  Update parm/transfer list files to match vetted GFSv16 set (NOAA-EMC#2517)
  Update gdas_gsibec_ver to 20240416 (NOAA-EMC#2497)
  Adding more cycles to gempak script gfs_meta_sa2.sh (NOAA-EMC#2518)
  Update gsi_enkf.sh hash to 457510c (NOAA-EMC#2514)
  Enable using the FV3_global_nest_v1 CCPP suite (NOAA-EMC#2512)
  CI Refactoring and STALLED case detection (NOAA-EMC#2488)
  Add C768 and C1152 S2SW test cases (NOAA-EMC#2509)
  Fix paths for refactored prepocnobs task (NOAA-EMC#2504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Wcoss2-Passed **Bot use only** CI testing on WCOSS for this PR has completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in GSI analysis due to inconsistent correlated error
5 participants