Add CCPP suite and FASTER option to UFS build #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build the UFS model
WalterKolczynski-NOAA
requested changes
Apr 23, 2024
parm/config/gfs/config.base
Outdated
| @@ -184,6 +184,7 @@ export DO_AERO="NO" | |||
| export WAVE_CDUMP="" # When to include wave suite: gdas, gfs, or both | |||
| export DOBNDPNT_WAVE="NO" | |||
| export FRAC_GRID=".true." | |||
| export CCPP_SUITE="FV3_GFS_v17_p8_ugwpv1" | |||
There was a problem hiding this comment.
Is there a reason to put the CCPP_SUITE in config.base rather than config.ufs? config.base is not a catch-all for all user-configurable settings; this should only be done if it is needed by additional jobs that are not using config.ufs.
There was a problem hiding this comment.
The only reason I have right now is that in many situations, one only need to modify one config file for new experiments.
I will remove this change. Thanks!
sorc/build_all.sh
Outdated
| @@ -16,7 +16,7 @@ function _usage() { | |||
| Builds all of the global-workflow components by calling the individual build | |||
| scripts in sequence. | |||
|
|
|||
| Usage: ${BASH_SOURCE[0]} [-a UFS_app][-c build_config][-d][-h][-j n][-v][-w] | |||
| Usage: ${BASH_SOURCE[0]} [-a UFS_app][-c build_config][-d][-h][-j n][-v][-w][-f] | |||
There was a problem hiding this comment.
Please maintain alphabetical order for the new option throughout this script.
sorc/build_ufs.sh
Outdated
| PDLIB="ON" | ||
|
|
||
| while getopts ":da:j:vw" option; do | ||
| while getopts ":da:j:vwf" option; do |
There was a problem hiding this comment.
These should be in alphabetical order as well. I recognize the d was already out-of-order, so just put the f after the a: and I'll fix the rest of the order later.
There was a problem hiding this comment.
sounds good. thanks!
sorc/build_all.sh
Outdated
| @@ -35,6 +35,8 @@ Usage: ${BASH_SOURCE[0]} [-a UFS_app][-c build_config][-d][-h][-j n][-v][-w] | |||
| Execute all build scripts with -v option to turn on verbose where supported | |||
| -w: | |||
| Use structured wave grid | |||
| -f: | |||
There was a problem hiding this comment.
This should be moved up to be in alphabetical order as well.
WalterKolczynski-NOAA
changed the title
WalterKolczynski-NOAA
changed the title
WalterKolczynski-NOAA
changed the title
WalterKolczynski-NOAA
requested changes
Apr 23, 2024
sorc/build_ufs.sh
Outdated
| case "${option}" in | ||
| d) BUILD_TYPE="Debug";; | ||
| a) APP="${OPTARG}";; | ||
| j) BUILD_JOBS="${OPTARG}";; | ||
| v) export BUILD_VERBOSE="YES";; | ||
| w) PDLIB="OFF";; | ||
| f) FASTER="ON";; |
There was a problem hiding this comment.
Please place this after the a) option as well.
Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>
WalterKolczynski-NOAA
approved these changes
Apr 23, 2024
WalterKolczynski-NOAA
added
the
CI-Hera-Ready
emcbot
added
CI-Hera-Building
|
CI Passed Hera at |
WalterKolczynski-NOAA
merged commit d0e1cc8
into
NOAA-EMC:develop
9 of 10 checks passed
danholdaway
added a commit
to danholdaway/global-workflow
that referenced
this pull request
Apr 23, 2024
* upstream/develop: Add CCPP suite and FASTER option to UFS build (NOAA-EMC#2521) New "atmanlfv3inc" Rocoto job (NOAA-EMC#2420) Hotfix to disable STALLED in CI as an error (NOAA-EMC#2523) Add restart on failure capability for the forecast executable (NOAA-EMC#2510) Update parm/transfer list files to match vetted GFSv16 set (NOAA-EMC#2517) Update gdas_gsibec_ver to 20240416 (NOAA-EMC#2497) Adding more cycles to gempak script gfs_meta_sa2.sh (NOAA-EMC#2518) Update gsi_enkf.sh hash to 457510c (NOAA-EMC#2514) Enable using the FV3_global_nest_v1 CCPP suite (NOAA-EMC#2512) CI Refactoring and STALLED case detection (NOAA-EMC#2488) Add C768 and C1152 S2SW test cases (NOAA-EMC#2509) Fix paths for refactored prepocnobs task (NOAA-EMC#2504)
|
Thanks, @WalterKolczynski-NOAA ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates related build scripts to (1) include the global-nest physics in the compilation step (2) be able to use the -DFASTER=ON compiling option through the "-f" command line switch.
Resolves #2520
Type of change
Change characteristics
How has this been tested?
Checklist
CONTRIBUTORS:
@SamuelTrahanNOAA