[Refactor]: Remove FIMSFrameAge #590
Labels
kind: refactor
Restructure code to improve the implementation of FIMS
P3
low priority task
theme: code cleanup
theme: R interface
Milestone
Comments
kellijohnson-NOAA
added
kind: refactor
15 tasks
kellijohnson-NOAA
pushed a commit
that referenced
this issue
May 14, 2024
by cleaning up the R code
Removes functions
* mkObj
* create_rcpp_interface_object
* use_module
* %>%
* FIMSFrameAge
Adds importFrom(TMB, MakeADFun) to package b/c TMB is no longer
explicitly used in the codebase. And, experimented with removing usethis
b/c it was also used in ./R/ but is still used in data-raw. It is now a
suggested package. Uses :: instead of importing functions, e.g.,
utils::head().
* Constricts line width to 80 characters
* Use full stops at the end of sentences
* Implement more spacing in between roxygen tags
* Move export tag to the end in most instances
* Use explicit brackets for if statements
* Remove duplicated code in gtest by calling run_gtest()
* Parameter and object names to snake_case
* Parameter, function, and object names, largely, w/o abbreviations
fix(run_gtest): Use paste() instead of paste0() to ensure proper spacing
which is not explicit in the instructions. With paste()
they can input as many additional arguments as they want and they are
all automatically separated, e.g.,
`run_gtest("--something", "--something-else")`
Close #588
Close #564
Close #590
Andrea-Havron-NOAA
pushed a commit
that referenced
this issue
May 25, 2024
by cleaning up the R code
Removes functions
* mkObj
* create_rcpp_interface_object
* use_module
* %>%
* FIMSFrameAge
Adds importFrom(TMB, MakeADFun) to package b/c TMB is no longer
explicitly used in the codebase. And, experimented with removing usethis
b/c it was also used in ./R/ but is still used in data-raw. It is now a
suggested package. Uses :: instead of importing functions, e.g.,
utils::head().
* Constricts line width to 80 characters
* Use full stops at the end of sentences
* Implement more spacing in between roxygen tags
* Move export tag to the end in most instances
* Use explicit brackets for if statements
* Remove duplicated code in gtest by calling run_gtest()
* Parameter and object names to snake_case
* Parameter, function, and object names, largely, w/o abbreviations
fix(run_gtest): Use paste() instead of paste0() to ensure proper spacing
which is not explicit in the instructions. With paste()
they can input as many additional arguments as they want and they are
all automatically separated, e.g.,
`run_gtest("--something", "--something-else")`
Close #588
Close #564
Close #590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Refactor request
Remove FIMSFrameAge because the complexity is not needed and it causes confusion. This will require moving some functionality from FIMSFrameAge to FIMSFrame and removing FIMSFrameAge from the vignette and all case studies that copied that part of the vignette into their quarto documents.
The text was updated successfully, but these errors were encountered: