-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ability for proportion female to vary by age #543
Conversation
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
==========================================
+ Coverage 75.28% 75.33% +0.04%
==========================================
Files 39 39
Lines 2080 2092 +12
Branches 140 141 +1
==========================================
+ Hits 1566 1576 +10
- Misses 471 473 +2
Partials 43 43 ☔ View full report in Codecov by Sentry. |
copied comment from other PR @k-doering-NOAA : @ChristineStawitz-NOAA I took a look and don't see any issues with this. I had a few questions, mostly for my understanding. The do not need to be resolved to merge, but answering them would help me :). One thing that I'm not sure about is how much documentation this should have - perhaps at least saying how users would use this -999 on the description of this PR might be helpful? That way, it will give us something to start from once writing more formal documentation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get the missing data to work in a case study. Coupled with the other reviews I think it's ready and will merge it in.
Users thought that they could set proportion_female but it was hard- coded to 0.5 on the back end. Now, it is back to just being a single value that is hard coded to 0.5. Tests have also changed back to 0.5. This partially reverts PR #543. And, was talked about in NOAA-FIMS/seaside-chats#7 and partially addresses #638.
Users thought that they could set proportion_female but it was hard- coded to 0.5 on the back end. Now, it is back to just being a single value that is hard coded to 0.5. Tests have also changed back to 0.5. This partially reverts PR #543. And, was talked about in NOAA-FIMS/seaside-chats#7 and partially addresses #638.
Users thought that they could set proportion_female but it was hard- coded to 0.5 on the back end. Now, it is back to just being a single value that is hard coded to 0.5. Tests have also changed back to 0.5. This partially reverts PR #543. And, was talked about in NOAA-FIMS/seaside-chats#7 and partially addresses #638.
Users thought that they could set proportion_female but it was hard- coded to 0.5 on the back end. Now, it is back to just being a single value that is hard coded to 0.5. Tests have also changed back to 0.5. This partially reverts PR #543. And, was talked about in NOAA-FIMS/seaside-chats#7 and partially addresses #638.
Users thought that they could set proportion_female but it was hard- coded to 0.5 on the back end. Now, it is back to just being a single value that is hard coded to 0.5. Tests have also changed back to 0.5. This partially reverts PR #543. And, was talked about in NOAA-FIMS/seaside-chats#7 and partially addresses #638.
What is the feature?
Allow proportion female to vary by age
How have you implemented the solution?
fims::Vector
of lengthnages
I did not add this to the estimation test, and have not yet tested if it can be estimated. I don't think we have a test data set to do that yet.
Does the PR impact any other area of the project?
Input is different because you can now add
proportion_female
as a fieldOutput has an extra parameter value if you estimate.
How to test this change
Developer pre-PR checklist