Add PCMDI metrics portrait plotter #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underwoo
reviewed
Mar 14, 2018
| try: | ||
| import vcs | ||
| except: | ||
| raise RuntimeError("Sorry your python is not build with VCS support and cannot generate portrait plots") |
There was a problem hiding this comment.
vcs is a python package available in PyPi (https://pypi.python.org/pypi/vcs). The message should indicate that package is not installed, not that python was not built with VCS support.
| import os | ||
| import sys | ||
| import re | ||
| import numpy as np |
There was a problem hiding this comment.
A similar check should be done for other non-standard python modules (like numpy, MV2, pcmdi_metrics).
There was a problem hiding this comment.
@underwoo new commits are in. If there are more changes and improvements needed, perhaps I could address it later after the initial push. Thank you.
…r-github Conflicts: analysis/pcmdimetrics/portrait4seasv1p1p1.py
underwoo
approved these changes
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCMDI metrics (aka PMP) portrait plotter on AM4/AMIP run is available via notebooks.