-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PCMDI metrics portrait plotter #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding the suggested changes. I'll reconsider the pull request once I get updates.
try: | ||
import vcs | ||
except: | ||
raise RuntimeError("Sorry your python is not build with VCS support and cannot generate portrait plots") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcs
is a python package available in PyPi (https://pypi.python.org/pypi/vcs). The message should indicate that package is not installed, not that python was not built with VCS support.
import os | ||
import sys | ||
import re | ||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A similar check should be done for other non-standard python modules (like numpy, MV2, pcmdi_metrics).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@underwoo new commits are in. If there are more changes and improvements needed, perhaps I could address it later after the initial push. Thank you.
…r-github Conflicts: analysis/pcmdimetrics/portrait4seasv1p1p1.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update. I'll get these merged.
PCMDI metrics (aka PMP) portrait plotter on AM4/AMIP run is available via notebooks.