-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hdf and mkl libraries to intel.mk #6
Conversation
Using relative links will allow the links to point to files on different branches
The compile script had a few errors that kept it from generating the Makefiles. Although, I think there are still issues that may keep the Makefiles from working correctly.
Following the SM2 public release, this adds pregenerated Makefiles that remove the need for external users to use mkmf to generate Makefiles.
MOM6, current, does not support openMP. The Makefile now does not pass the OPENMP macro to the MOM6 submake.
The -fp-model source option is needed to allow the model to run. Also corrected the NO_OVERRIDE_LIMIT macro option
The data files linked to in the documentation use 216 MPI processes for the run. Updated the run script to match.
Includes partial build and run instructions. Include updated links to data files.
Add links to the components added as submodule in the README.md file.
Correct spelling mistakes in README.md
Removed to no longer required build directory.
Added the git commit has for the components currently stored in the GFDL intenral git repositories. This is to help if/when there are support or community supplied bug fixes. Also corrected the clone --recursive option in the cloning instructions.
Also fix a few errors in the run script sample.
@underwoo I just looked at the namelist in the AM4 tar file, and it has
Either the run script should be updated, or the namelist should be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are just two minor things that need to be addressed
run/AM4_run_script.sh
Outdated
# openMP threads | ||
total_npes=216 | ||
total_npes=432 | ||
omp_threads=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current namelist has 2 atmos_threads, so either the namelist needs to be updated, or this line of the script needs to be updated.
run/AM4_run_script.sh
Outdated
@@ -113,7 +113,7 @@ then | |||
fi | |||
|
|||
## Use this section if you are untar'ing the input data ## | |||
## Not required if sing AM4.tar out of the box ## | |||
## Not required if sing AM4.tar out of the box ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a u missing from "using"
@underwoo You might also want to include instructions on how to use the options when running make like compiling with xHost or doing a debug compile. I could do that if you want, or you can include it with this pull request. |
I just logged into tiger and saw that my job ran to completion. It looks like putting -n in quotes made a difference. Or it could be that we reduced the number of arguments in the mpiexec_nopt from the first time we tried it. |
Corrected spelling of "using" in comment
@thomas-robinson I have pushed the two corrections. The documentation should be done in a separate PR. |
The
intel.mk
file didn't have the hdf5 and mkl libraries listed. These are now added.Also corrected a few inconsistencies in the run script example.