Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hdf and mkl libraries to intel.mk #6

Merged
merged 26 commits into from
Oct 1, 2018
Merged

Add hdf and mkl libraries to intel.mk #6

merged 26 commits into from
Oct 1, 2018

Conversation

underwoo
Copy link
Member

@underwoo underwoo commented Aug 8, 2018

The intel.mk file didn't have the hdf5 and mkl libraries listed. These are now added.

Also corrected a few inconsistencies in the run script example.

underwoo and others added 25 commits January 31, 2018 14:32
Using relative links will allow the links to point to files on different branches
The compile script had a few errors that kept it from generating the Makefiles.

Although, I think there are still issues that may keep the Makefiles from working correctly.
Following the SM2 public release, this adds pregenerated Makefiles that remove the need for external users to use mkmf to generate Makefiles.
MOM6, current, does not support openMP.  The Makefile now does not pass the OPENMP macro to the MOM6 submake.
The -fp-model source option is needed to allow the model to run.  Also corrected the NO_OVERRIDE_LIMIT macro option
The data files linked to in the documentation use 216 MPI processes for the run.  Updated the run script to match.
Includes partial build and run instructions.
Include updated links to data files.
Add links to the components added as submodule in the README.md file.
Correct spelling mistakes in README.md
Removed to no longer required build directory.
Added the git commit has for the components currently stored in the GFDL intenral git repositories.  This is to help if/when there are support or community supplied bug fixes.

Also corrected the clone --recursive option in the cloning instructions.
Also fix a few errors in the run script sample.
@underwoo underwoo added the bug label Aug 8, 2018
@thomas-robinson
Copy link
Member

@underwoo I just looked at the namelist in the AM4 tar file, and it has

        atmos_npes = 432
        atmos_nthreads = 2
        use_hyper_thread = .false.

Either the run script should be updated, or the namelist should be updated.

Copy link
Member

@thomas-robinson thomas-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are just two minor things that need to be addressed

# openMP threads
total_npes=216
total_npes=432
omp_threads=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current namelist has 2 atmos_threads, so either the namelist needs to be updated, or this line of the script needs to be updated.

@@ -113,7 +113,7 @@ then
fi

## Use this section if you are untar'ing the input data ##
## Not required if sing AM4.tar out of the box ##
## Not required if sing AM4.tar out of the box ##
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a u missing from "using"

@thomas-robinson
Copy link
Member

@underwoo You might also want to include instructions on how to use the options when running make like compiling with xHost or doing a debug compile. I could do that if you want, or you can include it with this pull request.

@thomas-robinson
Copy link
Member

I just logged into tiger and saw that my job ran to completion. It looks like putting -n in quotes made a difference. Or it could be that we reduced the number of arguments in the mpiexec_nopt from the first time we tried it.

@underwoo
Copy link
Member Author

@thomas-robinson I have pushed the two corrections.

The documentation should be done in a separate PR.

@underwoo underwoo merged commit 32b76eb into NOAA-GFDL:master Oct 1, 2018
@thomas-robinson thomas-robinson mentioned this pull request Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants