Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMS2_io: Unpack data #1231

Merged
merged 8 commits into from
Jun 16, 2023
Merged

FMS2_io: Unpack data #1231

merged 8 commits into from
Jun 16, 2023

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented May 23, 2023

Description

  • After reading the data, fms2_io checks for the add_offset and scale_factor attributes and unpacks the data.
  • Adds tests to make sure this capability works as expected.
  • Work around in amip_interp for reproducibility

Fixes #1229

How Has This Been Tested?
CI
@J-Lentz tested this with LM4P

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 requested a review from J-Lentz June 7, 2023 15:50
@uramirez8707 uramirez8707 marked this pull request as ready for review June 7, 2023 17:21
@uramirez8707 uramirez8707 changed the title Unpack data FMS2_io: Unpack data Jun 7, 2023
rem1776
rem1776 previously approved these changes Jun 16, 2023
@rem1776 rem1776 merged commit 22c498e into NOAA-GFDL:main Jun 16, 2023
@uramirez8707 uramirez8707 deleted the unpack_data branch August 24, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FMS IO does not properly decode NF_SHORT
2 participants