mixed precision: update mixedmode_base #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DL#1125) Co-authored-by: mlee03 <Mikyung.Lee@lscamd50-d.gfdl.noaa.gov>
Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
* fix: fms2 io performance update for domain_reads (NOAA-GFDL#1226) * fix: fms2 io performance update for compressed writes (NOAA-GFDL#1227) * chore: build/log updates for patch (NOAA-GFDL#1247) Co-authored-by: uramirez8707 <49168881+uramirez8707@users.noreply.github.com> Co-authored-by: rem1776 <Ryan.Mulhall@noaa.gov>
…re, and fms_mod (NOAA-GFDL#1239) (NOAA-GFDL#1258) * feat: mixed precision axis_utils2 (NOAA-GFDL#1104) * feat: mixed precision fms_mod (NOAA-GFDL#1147) * feat: horiz interp mixed precision (NOAA-GFDL#1067) * mixed precision sat_vapor_pressure (NOAA-GFDL#1095) * feat: add mixed precision axis_utils unit tests (NOAA-GFDL#1172) * fix: move type definitions to before first usage to fix nvhpc bug (NOAA-GFDL#1187) * fix: change allocatable type for intel errors (NOAA-GFDL#1221) Co-authored-by: Caitlyn McAllister <65364559+mcallic2@users.noreply.github.com> Co-authored-by: Jesse Lentz <42011922+J-Lentz@users.noreply.github.com> Co-authored-by: MiKyung Lee <58964324+mlee03@users.noreply.github.com>
…t nmls in mpp scripts (NOAA-GFDL#1158)
added 2 commits
June 28, 2023 10:56
uramirez8707
approved these changes
Jun 28, 2023
ganganoaa
reviewed
Jun 28, 2023
| !! | ||
| !! This may require that entries be moved from the beginning of the array to | ||
| !! the end. If no entries are moved (i.e., if lon(:) is already monotonic in | ||
| !! the range from lon_start to lon_start + 360), then istrt is set to 0. If |
There was a problem hiding this comment.
change lon_start to lon_strt for consistency
rem1776
approved these changes
Jul 5, 2023
mcallic2
approved these changes
Jul 6, 2023
|
@rem1776 I think this is ready to be merged into mixedmode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates mixedmode_base wrt main.