Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing script and CI updates #104

Merged
merged 39 commits into from
Oct 13, 2021
Merged

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Jun 23, 2021

Updates testing scripts with a new file for default setup and teardown functions and functions for generating input files.
Also adds a way to skip tests via an environment variable SKIP_TESTS and adds parallel tests to run when built with MPI.

Fixes #74

@ngs333 ngs333 self-requested a review June 23, 2021 23:35
Miguel Zuniga and others added 2 commits June 24, 2021 14:10
… the

same as that of the input_file in the case where the file type is not specified
by the format argument. Added function reset_in_format in mpp_io.c.
Use input_file format for the output NetCDF file type if the format argument is not specified
@rem1776 rem1776 marked this pull request as ready for review June 25, 2021 14:12
@ngs333
Copy link
Contributor

ngs333 commented Sep 17, 2021

@rem1776 @ceblanton
Looks pretty good. The merge will have conflicts since I took so long to review and master has since changed. I'll prepare a branch for the conflicts and let you know.

@ngs333
Copy link
Contributor

ngs333 commented Sep 17, 2021

@rem1776 @ceblanton I merged the branches and fixed the code my branch https://github.com/ngs333/FRE-NCtools/tree/testing .
One possibility is to merge my branch into ryans, and then merge ryans into master ?

@rem1776
Copy link
Contributor Author

rem1776 commented Sep 20, 2021

@ngs333 I merged in your 'testing' branch to this PR so it should be up to date now

@ngs333
Copy link
Contributor

ngs333 commented Sep 22, 2021

@ceblanton
Hi Chris, You reviewed and approved the PR a long time ago, but I guess since the update you may want to approve it again.
Thanks.

.gitmodules Show resolved Hide resolved
@ceblanton
Copy link
Contributor

@rem1776 thanks so much for these test improvements! I'm a little confused on when and how the parallel tests should run.

The parallel parts in Tests 3 and 4 should run if MPI is compiled but not through CI. Is that intentional?

Test15 looks like it runs properly in the github CI environment, but not gaea. I think it could work on PP/AN though

Can you run the parallel tests successfully on gaea or PP/AN?

t/Test15-regrid_land.sh Outdated Show resolved Hide resolved
rem1776 added 2 commits October 12, 2021 14:57
Skips parallel tests if SKIP_MPI_TEST is set during configure
@rem1776
Copy link
Contributor Author

rem1776 commented Oct 13, 2021

@ceblanton @ngs333 This should be good to go now. The parallel tests will run if configured using --with-mpi by default but will be skipped if SKIP_MPI_TEST is set. I had to replace openmpi with mpich on the container side but the mpirun's work now, test 4 seems to be too big to run in the CI so it's skipped but will run elsewhere just takes a while.

@ngs333
Copy link
Contributor

ngs333 commented Oct 13, 2021 via email

@ngs333 ngs333 merged commit e110850 into NOAA-GFDL:master Oct 13, 2021
ceblanton added a commit that referenced this pull request Oct 21, 2021
Two test updates that didn't make it in #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and enhance all test scripts
3 participants