-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing script and CI updates #104
Conversation
…into testing_input
… the same as that of the input_file in the case where the file type is not specified by the format argument. Added function reset_in_format in mpp_io.c.
Use input_file format for the output NetCDF file type if the format argument is not specified
Update to use RHEL/CentOS 7 Spack modulefiles for GFDL PP/AN site
ocean_model_grid_generator submodule to NCTools
@rem1776 @ceblanton |
@rem1776 @ceblanton I merged the branches and fixed the code my branch https://github.com/ngs333/FRE-NCtools/tree/testing . |
@ngs333 I merged in your 'testing' branch to this PR so it should be up to date now |
@ceblanton |
@rem1776 thanks so much for these test improvements! I'm a little confused on when and how the parallel tests should run. The parallel parts in Tests 3 and 4 should run if MPI is compiled but not through CI. Is that intentional? Test15 looks like it runs properly in the github CI environment, but not gaea. I think it could work on PP/AN though Can you run the parallel tests successfully on gaea or PP/AN? |
Skips parallel tests if SKIP_MPI_TEST is set during configure
@ceblanton @ngs333 This should be good to go now. The parallel tests will run if configured using |
In test 30, how is the status of executable md5sum checked?
…On Wed, Oct 13, 2021 at 12:58 PM Ryan Mulhall ***@***.***> wrote:
@ceblanton <https://github.com/ceblanton> @ngs333
<https://github.com/ngs333> This should be good to go now. The parallel
tests will run if configured using --with-mpi by default but will be
skipped if configured with SKIP_MPI_TEST is set. I had to replace openmpi
with mpich on the container side but the mpirun's work now, test 4 seems to
be too big to run in the CI so it's skipped but will run elsewhere just
takes a while.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#104 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKEC3TWSBHWDBO2PR36BLPTUGW3CVANCNFSM47GAKXMQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Two test updates that didn't make it in #104
Updates testing scripts with a new file for default setup and teardown functions and functions for generating input files.
Also adds a way to skip tests via an environment variable
SKIP_TESTS
and adds parallel tests to run when built with MPI.Fixes #74