ocean_model_grid_generator submodule to NCTools #115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ocean_model_grid_generator project ( https://github.com/NOAA-GFDL/ocean_model_grid_generator ) as a submodule to NCTools. One key goal is to have the
grid generator appear in as much as possible as just another tool of NCTools. To that end : the
grid generator has its own subdirectory under FRE-NCtools/tools; the grid generator (although it is a python script)
is installed along with the other NCTools scripts; and unit tests were created within NCTools that are in the same
directory as all the other NCTools unit tests, and are run by the CI.
There are two issues remaining:
that the NCTools subproject managers would only know of a problematic change in the submodule source repo if either a unit test fails, or if a submodule source repo developer informs us of a change. Of course, the submodule source repo is recursively cloned anew and tested every time any CI run is made, but is this enough?