Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocean_model_grid_generator submodule to NCTools #115

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

ngs333
Copy link
Contributor

@ngs333 ngs333 commented Aug 31, 2021

This pull request adds the ocean_model_grid_generator project ( https://github.com/NOAA-GFDL/ocean_model_grid_generator ) as a submodule to NCTools. One key goal is to have the
grid generator appear in as much as possible as just another tool of NCTools. To that end : the
grid generator has its own subdirectory under FRE-NCtools/tools; the grid generator (although it is a python script)
is installed along with the other NCTools scripts; and unit tests were created within NCTools that are in the same
directory as all the other NCTools unit tests, and are run by the CI.

There are two issues remaining:

  1. One of the four unit tests is commented out as the expected output is not produced. This is currently under investigation.
  2. The coordination between the two repositories is still TBD. With this proposed merge it is partly manual in the sense
    that the NCTools subproject managers would only know of a problematic change in the submodule source repo if either a unit test fails, or if a submodule source repo developer informs us of a change. Of course, the submodule source repo is recursively cloned anew and tested every time any CI run is made, but is this enough?

@ngs333 ngs333 linked an issue Aug 31, 2021 that may be closed by this pull request
@ngs333 ngs333 requested review from rem1776 and ceblanton and removed request for rem1776 August 31, 2021 17:44
@ngs333 ngs333 self-assigned this Aug 31, 2021
@ngs333 ngs333 changed the title Subp omgg ocean_model_grid_generator submodule to NCTools Aug 31, 2021
@ngs333 ngs333 merged commit d3f15b3 into NOAA-GFDL:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ocean model grid generator subproject
5 participants