Use input_file format for the output NetCDF file type if the format argument is not specified #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same as that of the input_file in the case where the file type is not specified by the format argument. Added function reset_in_format in mpp_io.c.
ceblanton
approved these changes
Jun 24, 2021
|
Thanks @ngs333, I also tested on PP/AN. Merging in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fregrid is modified to more closely work as indicated in its usage instructions. According to the
instructions: "When format is not specified, will use the format of input_file." Fregrid now temporarily stores the
netcdf format of the input_file file upon opening it, and if the case where the "format" argument is not specified, it uses
that stored format for the format of the output file. Function reset_in_format was added to mpp_io.
This PR is related to GFDL issue ticket #5019381 ("bronx-18: fregrid fails to remap tiled files with netcdf3/netcdf4 cconfusion") and was tested with the data indicated mentioned in that issue.
NOTE:: This PR replaces PR 106 because the automatic re-formatting created be Visual Code was too great.