Suggest target latitudes so that stretched grid would have both NS poles #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This commit adds a helper function to suggest target latitudes for which the generated stretched grid would include the North pole or the South pole (but not both) as grid points. - The value of suggested latitude is the closest to the input one that the user asks. - Having the poles as grid points have benefits of a more accurate exchange grid. Otherwise tiling errors creep out in the generated exchange grid.
- Implement the condition for the stretched grid to have both poles as grid points for a give stretch factor. - This subroutine lists possible target latitudes for a given stretch factor close to the requested target latitude such that the final grid has both poles as grid points. - Having a grid that includes both poles potentially avoids later issues with exchange grids.
- Implement the condition for the stretched grid to have both poles as grid points for a give stretch factor. - This subroutine lists possible target latitudes for a given stretch factor close to the requested target latitude such that the final grid has both poles as grid points. - Having a grid that includes both poles potentially avoids later issues with exchange grids.
ngs333
reviewed
May 13, 2022
There was a problem hiding this comment.
@nikizadehgfdl
Is the functionality in suggest_target_lats() being used by someone now or expected to
be used as is ? If so, should it be an option (and also user documentation in make_hgrid?
If not, should it just be commented out or possibly only use if compile-time flag is set?
|
The functionality is not being used right now. There is potential benefits for the users to see the message. |
ngs333
approved these changes
May 19, 2022
|
Hi @nikizadehgfdl |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general for a given stretch factor and target latitude the resulting stretch grid will not have the poles as grid points.
This may cause issues later with other tools such as exchange grid generator manifested as tiling errors and cells with a wrong land mask.