Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test_utils.bash to be POSIX safe #189

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Fixing test_utils.bash to be POSIX safe #189

merged 3 commits into from
Nov 17, 2022

Conversation

ilaflott
Copy link
Member

@ilaflott ilaflott commented Nov 8, 2022

test_utils.bash contained POSIX unsafe 'expr substr', replaced with shell parameter expansion to grab test directory numbers.

@ilaflott ilaflott added the bug label Nov 8, 2022
@ngs333 ngs333 linked an issue Nov 8, 2022 that may be closed by this pull request
@ilaflott ilaflott marked this pull request as ready for review November 9, 2022 20:49
@ngs333 ngs333 merged commit 9f9a3b2 into NOAA-GFDL:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of expr substr in tests is not POSIX
2 participants