Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fregrid to allow bilinear inpterpolation of vector fields. #215

Merged
merged 6 commits into from
Apr 6, 2023

Conversation

ngs333
Copy link
Contributor

@ngs333 ngs333 commented Mar 29, 2023

This PR modifies fregrid to allow the remapping of vector fields
provided bilinear interpolation is selected. It also clarifies the fregrid
introduction/usage statement and a couple of error messages.

This PR was tested on gaea with the files provided by @spencerkclark (described in #211). See these dirs:
/lustre/f2/dev/Spencer.Clark/2023-02-21-GRIDS/C96/
lustre/f2/dev/Spencer.Clark/2023-03-29-fregrid-example

@ngs333 ngs333 changed the title Modified fregrid to allow bilinear inpterpolation of vector fields. I… fregrid to allow bilinear inpterpolation of vector fields. Mar 29, 2023
@ngs333 ngs333 linked an issue Mar 29, 2023 that may be closed by this pull request
@ngs333 ngs333 marked this pull request as ready for review March 29, 2023 21:04
Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngs333! This is looking good. I added a few suggestions for some additional improvements to the documentation of this feature. Let me know if you have any questions.

tools/fregrid/fregrid.c Show resolved Hide resolved
tools/fregrid/fregrid.c Outdated Show resolved Hide resolved
tools/fregrid/fregrid.c Show resolved Hide resolved
tools/fregrid/fregrid.c Show resolved Hide resolved
tools/fregrid/fregrid.c Outdated Show resolved Hide resolved
@ngs333
Copy link
Contributor Author

ngs333 commented Apr 4, 2023

@spencerkclark , @ceblanton , @nikizadehgfdl
Hi All, In the latest version I incorporate Spencer's comments verbatim. Thanks Spencer!

nikizadehgfdl
nikizadehgfdl previously approved these changes Apr 6, 2023
ceblanton
ceblanton previously approved these changes Apr 6, 2023
spencerkclark
spencerkclark previously approved these changes Apr 6, 2023
Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

tools/fregrid/fregrid.c Outdated Show resolved Hide resolved
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
@ngs333 ngs333 merged commit cfbe75c into NOAA-GFDL:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to regrid vectors with fregrid raises an error
4 participants