-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to affinity.c #219
Conversation
check for sched_getaffinity; modified affinity.c to include configure.h.
@ceblanton @underwoo |
exists for the FMS doxygen system.
@ilaflott , @ceblanton |
Build on Macbook Air, 202 13inch, macOS 13.3.1 (ventura), intel chip failed. Though to be fair, it seems to fail building
Of course, I made sure i had this library:
Though, for what it's worth, I don't think this means the branch is necessarily at fault. Maybe my env is bunked up because i basically lean on homebrew to manage most of it. But maybe this is enough to say it doesn't pass the "scientist can easily use it with a mac" test. |
This PR improves affinity.c by:
This has been tested with gcc on analysis (an008) with and without the
--with-mpi
compilation flag using the canonical compilation method. It has also bee tested on an ubuntu laptop.I think it would be prudent to build and test on Apple OSX.
FYI, The new affinity.c #includes the generated configure.h file. Somehow FMS is able to compile affinity.c without this change - to my surprise.