-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1 Add OpenACC compile option to autotools #282
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by the copied over libfrencutils stuff. Is libfrencutils_acc a full copy of all the routines in the original libfrencutils with any gpu modifications needed? or is it supposed to only contain routines that were modified, with fregrid_acc using original versions when applicable?
I don't see fregrid_acc calling anything with the _acc
added, so is it just using the orignal libfrencutils?
@rem1776 currently in this PR, all files in the directories |
So are you going to be removing the unused/unmodified routines in libfrencutils_acc as part of those updates? If thats the case then i think we should probably only add those routines to begin with, maybe we can just add the acc versions to the same libfrencutils files instead of creating a copy? Saves us the confusion of having copies of things, and having to add a lot of code just to delete it since it'll all still be in the git history. |
Got it got it, yup I was going to remove functions as we go along (also thought it would be easier for debugging), but it is needless code that has to be carried around and removed functions that are needed in the future can be added back in. Okay, will remove all repetitive functions in fregrid_acc and libfrencutils_acc |
@rem1776 Perhaps it's ready. Decided to start almost from scratch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks for making those changes i hope they weren't too annoying.
After this goes in I have an m4 file in the gpu_dev branch for the configure checks with the openacc flag, I'll make a PR for it. It'll just adjust the flag for different compilers if needed and make sure it works.
No problem at all, I think this might be a better start for fregrid_acc. @bensonr @nikizadehgfdl @thomas-robinson @ceblanton, I think this PR is ready for your approvals 😇 |
In this PR,
_acc
. All OpenACC development for OpenACC enabledfregrid
will occur in these two directories.-acc
compiler flag toFCFLAGS
and to compilefregrid_acc