Make hgrid combo #94
Merged
Make hgrid combo #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPDATE with NOAA base MAr 26
Merging GFDL master to ngs333
…e used in GR runs.
added 2 commits
May 26, 2021 12:21
…ases. No memory leaks detected and awnsers reproducing.
ceblanton
approved these changes
May 27, 2021
bensonr
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several invalid memory access, memory leaks, and some non-critical compiler warnings.
This PR also re-introduces a second version of function create_gnomonic_cubic_grid in order to
reproduce the pre-multinest awnsers in global refinement runs and also avoid some invalid memory access.
This code was tested on gfdl workstations, analysis, and an AMD box and with Intel and gnu compilers. The make_hgrid_segfaults of Test04 unit test does not appear any longer. Intel inspector indicates that invalid memory access and memory leaks within our custom code are not present under various of runs ( ,eg,, subnest producing runs, global refinement runs, regular non-nest runs, etc).