Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of public post_data_1d_k is incompatible with ocean_BGC #168

Closed
adcroft opened this issue Jul 18, 2022 · 2 comments · Fixed by #169
Closed

Removal of public post_data_1d_k is incompatible with ocean_BGC #168

adcroft opened this issue Jul 18, 2022 · 2 comments · Fixed by #169
Labels
bug Something isn't working

Comments

@adcroft
Copy link
Member

adcroft commented Jul 18, 2022

We recently removed the statement

public post_data_1d_k

from src/framework/MOM_diag_mediator.F90. Unfortunately, ocean_BGC/generic_tracers/generic_tracer_utils.F90 has the line:

    use MOM_diag_mediator, only : post_data_MOM=>post_data, post_data_1d_k

so our BGC models no longer compile.
@adcroft adcroft added invalid This doesn't seem right bug Something isn't working and removed invalid This doesn't seem right labels Jul 18, 2022
@Hallberg-NOAA
Copy link
Member

As of July 5. 2022, the offending line has been removed from the master branch of ocean_BGC/generic_tracers/generic_tracer_utils.F90. However, the deprecated interface should be restored to MOM_diag_mediator.F90 to give a decent interval for this change to ocean_BGC to become widely used.

@nikizadehgfdl
Copy link

I updated the master branch of ocean_BGC to divert post_data_1d_k to post_data_MOM. Regression tests passed.

Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Jul 18, 2022
@Hallberg-NOAA
+Restored public interface to post_data_1d_k
fb679b5 
  Made post_data_1d_k publicly visible once again, rather than requiring calls
to use post_data, to support backward compatibility with older versions of the
ocean_BGC code.  This interface was removed from public visibility as a part of
github.com/NOAA-GFDL/pull/107, but it caused problems with some of GFDL's
Earth System Models, as noted in NOAA-GFDL#168.
All answers are bitwise identical for any cases that compiled before.
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Jul 18, 2022
Merged
@Hallberg-NOAA Hallberg-NOAA linked a pull request Jul 18, 2022 that will close this issue
+Restored public interface to post_data_1d_k #169
Merged
marshallward pushed a commit that referenced this issue Jul 18, 2022
@Hallberg-NOAA @marshallward
+Restored public interface to post_data_1d_k
2217e63 
  Made post_data_1d_k publicly visible once again, rather than requiring calls
to use post_data, to support backward compatibility with older versions of the
ocean_BGC code.  This interface was removed from public visibility as a part of
github.com//pull/107, but it caused problems with some of GFDL's
Earth System Models, as noted in #168.
All answers are bitwise identical for any cases that compiled before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

+Restored public interface to post_data_1d_k Hallberg-NOAA/MOM6
3 participants
@adcroft @nikizadehgfdl @Hallberg-NOAA