-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace findloc() with user-defined find_index #136
Conversation
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #136 +/- ##
=========================================
Coverage 33.45% 33.45%
=========================================
Files 262 262
Lines 71385 71385
Branches 13323 13323
=========================================
Hits 23884 23884
Misses 43029 43029
Partials 4472 4472 Continue to review full report at Codecov.
|
This PR is required in order to switch the CI to the FMS2 infra (NOAA-GFDL/MOM6-examples#353). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15675 (and prior PRs)
This patch replaces the instances of findloc() with a new function, find_index. They should be functionally equivalent. findloc() is a F2008 intrinsic which returns the index of the first instance of a value in an array. Support is still spotty on some older compilers in active use, so this function is the safer alternative.
Sorry this PR was broken and does not even compile. Will submit a patch ASAP... |
It did compile, and ran fine! https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15675 |
Indeed, garbage commits to the FMS2 infra do not break the FMS1 build 🤣 |
update to main 20240729 commit (gfdl-to-main-2024-05-31)
This patch replaces the instances of findloc() with a new function,
find_index. They should be functionally equivalent.
findloc() is a F2008 intrinsic which returns the index of the first
instance of a value in an array. Support is still spotty on some older
compilers in active use, so this function is the safer alternative.