(*)Correct salinity rescaling in OBCs from files #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy scaling factors for tracers in scale_factor_from_name, to accommodate the possibility that calls to register_segment_tracer might occur before calls to initialize_segment_data, as they do for temperature and salinity, or afterwards as they do for many user-defined tracers. This commit addresses the issue with the dumbbell subdomain test case not exhibiting proper rescaling for salinity as described in NOAA-GFDL#148. Some incorrect unit descriptions in comments were also corrected, and the tracer name comparisons for setting rescaling were made case-insensitive to handle some inconsistently cased name declarations. All answers without dimensional rescaling are bitwise identical.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #161 +/- ##
============================================
- Coverage 34.02% 34.01% -0.01%
============================================
Files 259 259
Lines 70204 70209 +5
Branches 13013 13015 +2
============================================
Hits 23884 23884
- Misses 41822 41826 +4
- Partials 4498 4499 +1
Continue to review full report at Codecov.
|
|
Yes, this now works for me. I approve! |
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16103 ✔️ |
marshallward
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy scaling factors for tracers in scale_factor_from_name, to accommodate the
possibility that calls to register_segment_tracer might occur before calls to
initialize_segment_data, as they do for temperature and salinity, or afterwards
as they do for many user-defined tracers. This commit addresses the issue with
the dumbbell subdomain test case not exhibiting proper rescaling for salinity as
described in #148. Some incorrect unit
descriptions in comments were also corrected, and the tracer name comparisons
for setting rescaling were made case-insensitive to handle some inconsistently
cased name declarations. All answers without dimensional rescaling are bitwise
identical.