Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seg offset #171

Merged
merged 2 commits into from
Jul 27, 2022
Merged

Seg offset #171

merged 2 commits into from
Jul 27, 2022

Conversation

kshedstrom
Copy link

Change suggested by @Hallberg-NOAA to shorten some expressions.

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #171 (43e3f7d) into dev/gfdl (48875ea) will decrease coverage by 0.01%.
The diff coverage is 7.36%.

❗ Current head 43e3f7d differs from pull request most recent head 9cbeb59. Consider uploading reports for the commit 9cbeb59 to get more accurate results

@@             Coverage Diff              @@
##           dev/gfdl     #171      +/-   ##
============================================
- Coverage     34.01%   34.00%   -0.02%     
============================================
  Files           259      259              
  Lines         70209    70250      +41     
  Branches      13012    13016       +4     
============================================
+ Hits          23884    23886       +2     
- Misses        41826    41865      +39     
  Partials       4499     4499              
Impacted Files Coverage Δ
src/diagnostics/MOM_diagnostics.F90 68.25% <ø> (ø)
src/framework/MOM_diag_mediator.F90 53.02% <ø> (ø)
src/initialization/MOM_state_initialization.F90 17.23% <ø> (ø)
src/user/DOME2d_initialization.F90 0.00% <0.00%> (ø)
src/user/DOME_initialization.F90 0.00% <0.00%> (ø)
src/user/dumbbell_initialization.F90 0.00% <0.00%> (ø)
src/core/MOM_open_boundary.F90 23.02% <11.11%> (+0.05%) ⬆️
src/core/MOM_stoch_eos.F90 11.11% <20.00%> (ø)
src/core/MOM_isopycnal_slopes.F90 59.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48875ea...9cbeb59. Read the comment docs.

Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice simplification of the code, making it much clearer to read.

@Hallberg-NOAA Hallberg-NOAA added the refactor Code cleanup with no changes in functionality or results label Jul 19, 2022
@marshallward
Copy link
Member

@kshedstrom Ok to squash these two commits into one? Just confirming that it's not in dev/ESMG.

@kshedstrom
Copy link
Author

Please do squash them.

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16202 ✔️

@marshallward marshallward merged commit c598441 into NOAA-GFDL:dev/gfdl Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code cleanup with no changes in functionality or results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants