-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seg offset #171
Seg offset #171
Conversation
- suggested by @Hallberg-NOAA in the discussion for #164
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #171 +/- ##
============================================
- Coverage 34.01% 34.00% -0.02%
============================================
Files 259 259
Lines 70209 70250 +41
Branches 13012 13016 +4
============================================
+ Hits 23884 23886 +2
- Misses 41826 41865 +39
Partials 4499 4499
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice simplification of the code, making it much clearer to read.
@kshedstrom Ok to squash these two commits into one? Just confirming that it's not in dev/ESMG. |
Please do squash them. |
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/16202 ✔️ |
Change suggested by @Hallberg-NOAA to shorten some expressions.