Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+FIX_UNSPLIT_DT_VISC_BUG is now UNSPLIT_DT_VISC_BUG #536

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

Hallberg-NOAA
Copy link
Member

Renamed the runtime parameter FIX_UNSPLIT_DT_VISC_BUG to UNSPLIT_DT_VISC_BUG (with a switch between the meanings of true and false for the two parameters) for consistency with the syntax of other bug-fix flags in MOM6 and to partially address dev/gfdl MOM6 issue #237. Input parameter files need not be changed right away because MOM6 will still work if FIX_UNSPLIT_DT_VISC_BUG is specified instead of UNSPLIT_DT_VISC_BUG, but UNSPLIT_DT_VISC_BUG will be logged, so there are changes to the MOM_parameter_doc files. By default or with existing input parameter files, all answers are bitwise identical, and there is error handling if inconsistent settings of FIX_UNSPLIT_DT_VISC_BUG and UNSPLIT_DT_VISC_BUG are both specified.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (90de5de) 37.44% compared to head (bfc1e8c) 37.45%.

Files Patch % Lines
src/core/MOM_dynamics_unsplit.F90 85.71% 1 Missing and 1 partial ⚠️
src/core/MOM_dynamics_unsplit_RK2.F90 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           dev/gfdl     #536      +/-   ##
============================================
+ Coverage     37.44%   37.45%   +0.01%     
============================================
  Files           270      270              
  Lines         79673    79695      +22     
  Branches      14828    14830       +2     
============================================
+ Hits          29836    29853      +17     
- Misses        44289    44291       +2     
- Partials       5548     5551       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

  Renamed the runtime parameter FIX_UNSPLIT_DT_VISC_BUG to UNSPLIT_DT_VISC_BUG
(with a switch between the meanings of true and false for the two parameters)
for consistency with the syntax of other bug-fix flags in MOM6 and to partially
address dev/gfdl MOM6 issue mom-ocean#237.  Input parameter files need not be changed
right away because MOM6 will still work if FIX_UNSPLIT_DT_VISC_BUG is specified
instead of UNSPLIT_DT_VISC_BUG, but UNSPLIT_DT_VISC_BUG will be logged, so there
are changes to the MOM_parameter_doc files.   By default or with existing input
parameter files, all answers are bitwise identical, and there is error handling
if inconsistent settings of FIX_UNSPLIT_DT_VISC_BUG and UNSPLIT_DT_VISC_BUG are
both specified.
@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/21735 ✔️ 🟡

@marshallward marshallward merged commit eac3bb3 into NOAA-GFDL:dev/gfdl Dec 21, 2023
12 checks passed
@Hallberg-NOAA Hallberg-NOAA deleted the UNSPLIT_DT_VISC_BUG branch May 10, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants