Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locate the experiment pp.yamls relative to the main yaml dir #137

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ceblanton
Copy link
Collaborator

@ceblanton ceblanton commented Jul 30, 2024

Describe your changes

fre pp configure-yaml was unable to locate the child experiment pp.yaml. An update to prepend the directory containing the main yaml resolves the problem.

Issue ticket number and link (if applicable)

#99

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@ceblanton ceblanton requested a review from singhd789 July 30, 2024 15:46
@ceblanton
Copy link
Collaborator Author

Tiny fix for locating the experiment yamls relative to the main yaml.

@ilaflott
Copy link
Member

this pipeline's success depends on #140

@ilaflott
Copy link
Member

this pipeline's success depends on #140

actually, that's not quite true (yet). but intakebuilder will be deleted someday. the pipeline seemed to fail because the connection to the conda-forge channel seemed to die randomly. rerunning

@ceblanton
Copy link
Collaborator Author

Agreed. the pipeline fail was a weird one-off error related to conda-forge.

@ilaflott ilaflott merged commit fce44b1 into main Jul 31, 2024
3 checks passed
@ilaflott ilaflott deleted the 99.relative-path-child-yaml branch July 31, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants