Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Always include minutes in initialization time #346

Conversation

esheehan-gsl
Copy link
Contributor

To ensure that our Zarr groups have a uniform format, we append ":00" to the init time if the ingested NetCDF file has only a year, month, day, and hour for the init time.

To ensure that our Zarr groups have a uniform format, we append ":00" to
the init time if the ingested NetCDF file has only a year, month, day,
and hour for the init time.
@esheehan-gsl esheehan-gsl linked an issue Jun 6, 2023 that may be closed by this pull request
@esheehan-gsl esheehan-gsl self-assigned this Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Code Coverage

Package Line Rate Branch Rate Health
unified_graphics 90% 87%
unified_graphics.etl 97% 95%
Summary 93% (398 / 430) 90% (94 / 104)

Minimum allowed line rate is 60%

@esheehan-gsl esheehan-gsl temporarily deployed to vlab June 6, 2023 20:16 — with GitHub Actions Inactive
Copy link
Collaborator

@ian-noaa ian-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@esheehan-gsl esheehan-gsl merged commit 8f2613a into main Jun 6, 2023
@esheehan-gsl esheehan-gsl deleted the 345-zarr-groups-without-minutes-in-the-timestamp-cant-be-found branch June 6, 2023 20:18
@esheehan-gsl esheehan-gsl temporarily deployed to vlab June 6, 2023 20:18 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zarr groups without minutes in the timestamp can’t be found
2 participants