This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Parquet data storage #348
Merged
Parquet data storage #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some assertions to check that the parquet file is being created during ETL. This is getting to be a bit much with the Zarr and database stuff as well. If this works out, we should consider using just the Parquet files for diag data and removing Zarr and Postgres from the equation.
This is needed to write to Parquet files.
I think following pytest's recommended pattern for multiple asserts makes the tests a little easier to follow. Each test is a parameterized method, grouped by what action is being tested. The "act" step of the test is encompassed in a fixture on the class. Each method then only has to assert the state it expects, so it's a little more clear what each expected outcome is. See: https://docs.pytest.org/en/7.3.x/how-to/fixtures.html#running-multiple-assert-statements-safely
We need to ensure that the parquet file is being updated correctly, and that the database has both analyses.
This needs to be present to allow us to concatenate variables into a single Parquet file.
Instead of combining all of the variables into a single parquet file for the model, I've decided to separate them. Some of the variables, such as wind, have columns that are unique to that variable; I think this is reason enough to store them separately, otherwise all of the other variables will just NaN values in those columns, which seems silly. Some preliminary testing suggests this might actually save space.
This seems like a silly type hint from pandas-stubs, because the tuple works just fine, but I don't think it's causing any harm.
Minimum allowed line rate is |
ian-noaa
approved these changes
Jun 14, 2023
| @pytest.fixture | ||
| @pytest.fixture(scope="session") |
There was a problem hiding this comment.
This is a good call. If this was function-scoped it seems like the factory function wasn't really being used before - it'd need to recreate the data each time it was invoked.
Comment on lines
+48
to
+61
| class TestSaveNew: | ||
| @pytest.fixture(scope="class", autouse=True) | ||
| def dataset(self, model, diag_dataset, session, zarr_file): | ||
| (mdl, system, domain, background, frequency) = model | ||
| ps = diag_dataset( | ||
| "ps", | ||
| "2022-05-05T14:00", | ||
| "anl", | ||
| mdl, | ||
| system, | ||
| domain, | ||
| frequency, | ||
| background, | ||
| ) |
There was a problem hiding this comment.
This is a nice way to consolidate setup and handle multiple assert's. Thanks for the doc link!
|
Yeah, the Parquet file should get written locally as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add storage of diag data as partitioned Parquet files. This should be more suitable for our time series visualizations.