This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Fit the map to the data #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a GeoJSON FeatureCollection from the data that we can pass to D3's fitSize method to zoom the map to the data. I tried using d3.extent to find the range of the longitude and latitude in the data from which I created a FeatureCollection with just 2 points, but the longitude range ended up being nearly [-180, 180], so it never actually zoomed the map. Seems like maybe D3 is doing something smart to handle collections that wrap around the globe, or possibly there's some unaccounted for weirdness in the data.
esheehan-gsl
deleted the
447-map-extent-always-shows-all-of-north-america
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a GeoJSON FeatureCollection from the data that we can pass to D3's fitSize method to zoom the map to the data.
I tried using d3.extent to find the range of the longitude and latitude in the data from which I created a FeatureCollection with just 2 points, but the longitude range ended up being nearly [-180, 180], so it never actually zoomed the map. Seems like maybe D3 is doing something smart to handle collections that wrap around the globe, or possibly there's some unaccounted for weirdness in the data.
Fixes #447