Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fit the map to the data #476

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

esheehan-gsl
Copy link
Contributor

@esheehan-gsl esheehan-gsl commented Dec 21, 2023

Create a GeoJSON FeatureCollection from the data that we can pass to D3's fitSize method to zoom the map to the data.

I tried using d3.extent to find the range of the longitude and latitude in the data from which I created a FeatureCollection with just 2 points, but the longitude range ended up being nearly [-180, 180], so it never actually zoomed the map. Seems like maybe D3 is doing something smart to handle collections that wrap around the globe, or possibly there's some unaccounted for weirdness in the data.

Fixes #447

Create a GeoJSON FeatureCollection from the data that we can pass to
D3's fitSize method to zoom the map to the data.

I tried using d3.extent to find the range of the longitude and latitude
in the data from which I created a FeatureCollection with just 2 points,
but the longitude range ended up being nearly [-180, 180], so it never
actually zoomed the map. Seems like maybe D3 is doing something smart to
handle collections that wrap around the globe, or possibly there's some
unaccounted for weirdness in the data.
@esheehan-gsl esheehan-gsl linked an issue Dec 21, 2023 that may be closed by this pull request
@esheehan-gsl esheehan-gsl merged commit 4430c09 into main Dec 21, 2023
5 checks passed
@esheehan-gsl esheehan-gsl deleted the 447-map-extent-always-shows-all-of-north-america branch December 21, 2023 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map extent always shows all of North America
1 participant