giuh_time_scaling

[ajkhattak]

The PR fixes GIUH time scaling reported in the issue. The giuh ordinates from percentage per hour are scaled to account for LGAR model timestep.

Additions

• Modified the Initialized function to extend the GIUH array for the scaled values

Removals

• None

Changes

• no significant changes other than modified giuh array at the initialization time

Testing

1. Done

Screenshots

The giuh runoff using the old code has a high peak and quick recession, while the new code (taking into account time scaling) has a lower peak and relatively smooth rising and falling limbs, which makes sense.

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Passes all existing automated tests
• Reviewers requested with the Reviewers tool ➡️

[ajkhattak]

@PhilMiller Thanks Phil for your suggestions, they have been incorporated. please have a look and see if you have more suggestions. Although I added you as a reviewer by mistake, it turned out to be a useful mistake. Appreciate it!

[PhilMiller]

You're welcome. I'm happy to help.

And no worries, you didn't accidentally add me as a reviewer - I'm a newcomer to the NWM enterprise, subscribed to activity on a bunch of the NOAA-OWP repositories. I skim whatever PRs I see come up as a way of gaining more fluency with the overall codebase.

[PhilMiller]

I can't speak to the substance of the change, but the issue I saw is addressed, so no longer 'Request changes'

Fixed

[peterlafollette]

I tested it in ngen and standalone, both worked well. I played around with the GIUH ordinates and they did what I expected them to. Everything looks good.

[peterlafollette]

And thanks Phil for the suggestion!