Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable name is wrong; in the result baseflow is not generated #83

Open
RY4GIT opened this issue Apr 5, 2023 · 0 comments
Open

Variable name is wrong; in the result baseflow is not generated #83

RY4GIT opened this issue Apr 5, 2023 · 0 comments

Comments

@RY4GIT
Copy link
Contributor

RY4GIT commented Apr 5, 2023

This issue is identified in PR #60 and #63

Current behavior

Variable names were inconsistent. Fluxes from both soil & groundwater storages were named as primary_flux and secondary_flux in the main execusion vs. primary_flux**_m** and secoundary_flux**_m** in conceptual_reservoir_flux_calc.

As a result, the baseflow was entirely missing in CFE. Fluxes calculated in conceptual_reservoir_flux_calc were not passed the main flux calculation.

Change needed

  • Change variable name 'primary_flux' to 'primary_flux_m'
  • Change variable name 'secondary_flux' to 'secondary_flux_m'
@RY4GIT RY4GIT changed the title Variable name is wrong Variable name is wrong: in the result baseflow is not generated Apr 5, 2023
@RY4GIT RY4GIT changed the title Variable name is wrong: in the result baseflow is not generated Variable name is wrong; in the result baseflow is not generated Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant