Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the main cause of missing baseflow. Variable name primary & secondary fluxes were not consistent #60

Closed
wants to merge 2 commits into from

Conversation

RY4GIT
Copy link
Contributor

@RY4GIT RY4GIT commented Apr 12, 2022

[Short description explaining the high-level reason for the pull request]

Variable names were inconsistent. Fluxes from both soil & groundwater storages were named as primary_flux and secondary_flux in the main execusion vs. primary_flux**_m** and secoundary_flux**_m** in conceptual_reservoir_flux_calc.

As a result, the baseflow was entirely missing in CFE. Fluxes calculated in conceptual_reservoir_flux_calc were not passed the main flux calculation.

I fixed the bug in the Python version on bmi-python, but here I am trying to make a similar pull request in the C version.

Changes

  • Changed variable name 'primary_flux' to 'primary_flux_m'
  • Changed variable name 'secondary_flux' to 'secondary_flux'
    On both soil and groundwater storage

Testing

  1. Not tested as I am not proficient in C. I appreciate somebody could check it.

@RY4GIT RY4GIT changed the title debugged the main cause of missing baseflow. Variable name primary & secondary fluxes were wrong Fixed the main cause of missing baseflow. Variable name primary & secondary fluxes were wrong Apr 13, 2022
@RY4GIT RY4GIT changed the title Fixed the main cause of missing baseflow. Variable name primary & secondary fluxes were wrong Fixed the main cause of missing baseflow. Variable name primary & secondary fluxes were not consistent Apr 13, 2022
@RY4GIT RY4GIT closed this Sep 21, 2022
@RY4GIT RY4GIT deleted the bug-fix-ra branch September 21, 2022 17:30
@RY4GIT RY4GIT restored the bug-fix-ra branch December 8, 2022 22:39
@RY4GIT RY4GIT reopened this Dec 8, 2022
@RY4GIT
Copy link
Contributor Author

RY4GIT commented Dec 8, 2022

I realized that I accidentally closed the pull request and branch.
Reopened because the issue is still there (the pull request may not automatically merge, so please see the suggested changes).

@RY4GIT RY4GIT closed this by deleting the head repository Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant