Fixed the main cause of missing baseflow. Variable name primary & secondary fluxes were not consistent #60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Variable names were inconsistent. Fluxes from both soil & groundwater storages were named as primary_flux and secondary_flux in the main execusion vs. primary_flux**_m** and secoundary_flux**_m** in conceptual_reservoir_flux_calc.
As a result, the baseflow was entirely missing in CFE. Fluxes calculated in conceptual_reservoir_flux_calc were not passed the main flux calculation.
I fixed the bug in the Python version on bmi-python, but here I am trying to make a similar pull request in the C version.
Changes
On both soil and groundwater storage
Testing