debugged. variable name (soil_moisture_deficit) was wrong #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #53 |
madMatchstick
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Good catch @RY4GIT and thank you again for your engagement and help with updates/bug-fixes.
Moreso, note that we are in the process of moving the Python version of CFE to it's own development branch, here. The C-version in master branch will likely function as the primary submodule for the NextGen framework, at least for now.
Please continue to reach out with comments/concerns regarding model code.
-Cheers!
|
Thank you very much @madMatchstick and @SnowHydrology for involving my comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed the variable name 'soil_moisture_deficit' to 'soil_moisture_deficit_m'.
I guess it was left unfound because the condition "cfe_state.previous_flux_perc_m > cfe_state.soil_reservoir_storage_deficit_m" was rarely reached. The program stopped with an error that it cannot find 'soil_moisture_deficit'. Tested with 'soil_moisture_deficit_m' and working okay.